feat: Enhance memory allocation and SDK generation #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `GetMemAlloc` in `IMemAlloc.h` to use `__declspec(dllimport)` for proper external linkage. Improved SDK generation in `startup.cpp` by adding support for dumping enums and classes from global type scopes.
es3n1n
changed the title
es3n1n
requested changes
May 11, 2025
| auto type_scopes = sdk::g_schema->GetTypeScopes(); | ||
| assert(type_scopes.Count() > 0 && "sdk is outdated"); | ||
|
|
||
|
|
| } | ||
|
|
||
| // @note: @es3n1n: Obtaining type scopes and generating sdk | ||
| const auto type_scopes = sdk::g_schema->GetTypeScopes(); |
Collaborator
There was a problem hiding this comment.
why did you remove const?
Comment on lines
+92
to
+104
| const auto global_scope = sdk::g_schema->GlobalTypeScope(); | ||
| auto current_enums = global_scope->GetEnumBindings(); | ||
| for (auto el : current_enums.GetElements()) { | ||
| auto& dump{dumped_modules.emplace(el->m_pszModule, unique_module_dump{}).first->second}; | ||
| dump.enums.emplace(el->m_pszName, el); | ||
| } | ||
|
|
||
| auto current_classes = global_scope->GetClassBindings(); | ||
| for (auto el : current_classes.GetElements()) { | ||
| auto& dump{dumped_modules.emplace(el->m_pszModule, unique_module_dump{}).first->second}; | ||
| dump.classes.emplace(el->m_pszName, el); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Not a huge fan of code repetition here. How about making a lambda that takes a pointer to CSchemaSystemTypeScope and does this processing so that we can just call lambda in the loop and for the global scope?
| }; | ||
|
|
||
| extern IMemAlloc* GetMemAlloc(); | ||
| extern "C" __declspec(dllimport) IMemAlloc* GetMemAlloc(); |
Collaborator
There was a problem hiding this comment.
__declspec is a microsoft-specific attribute. This code would not work on linux.
Would really love to put this under a macro, but for now we have only one use case so we can just inline it.
Suggested change
| extern "C" __declspec(dllimport) IMemAlloc* GetMemAlloc(); | |
| #if defined(_WIN64) || defined(_WIN32) | |
| extern "C" __declspec(dllimport) IMemAlloc* GetMemAlloc(); | |
| #else | |
| extern "C" IMemAlloc* GetMemAlloc(); | |
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
GetMemAllocinIMemAlloc.hto use__declspec(dllimport)for proper external linkage. Improved SDK generation instartup.cppby adding support for dumping enums and classes from global type scopes.