fix: Dockerstats receiver otel golden-metrics #2407

NSSPKrishna · 2025-11-04T13:59:56Z

Relevant information

This fixes the golden signal metrics for the dockerstats otel

Checklist

I've read the guidelines and understand the acceptance criteria.
The value of the attribute marked as identifier will be unique and valid.
I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

lujop

Validations don't pass, look at networkTrafficTotal where you have bad identation

lujop · 2025-11-04T16:21:00Z

entity-types/infra-container/golden_metrics.stg.yml

+      select: max(docker.container.cpuPercent) or max(k8s.container.cpuCoresUtilization) AS 'CPU Utilization (%)'
+    opentelemetry:
+      # via dockerstatsreceiver & kubeletstatsreceiver – which send equivalent value named container.cpu.usage, container.cpu.utilization (deprecated)
+      select: max(container.cpu.usage or container.cpu.utilization) AS 'CPU Utilization (%)'


Is max this way correct, in some places you use the or inside and in others outside?

There are two fields that a customer can set up in their OTel configuration, enabling the ingestion of either or both simultaneously, specifically for the dockerstats receiver. The other queries listed here pertain to metrics from the Kubernetes receiver, which are separate and not currently within scope. Just as a note, this change has already been merged into the main branch.

entityBot

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT rate(sum(container.cpu.usage.total)/1E9, 1 second) AS 'CPU usage (cores)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT rate(sum(container.network.rx_bytes), 1 second) + rate(sum(container.network.tx_bytes), 1 second) AS 'Network traffic (bytes per second)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

Let's validate those changes.

entityBot

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT rate(sum(container.cpu.usage.total)/1E9, 1 second) AS 'CPU usage (cores)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT rate(sum(container.network.rx_bytes), 1 second) + rate(sum(container.network.tx_bytes), 1 second) AS 'Network traffic (bytes per second)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

entityBot · 2025-11-08T14:38:15Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

entityBot · 2025-11-12T12:55:14Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Let's validate those changes.

entityBot

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT (sum(container.cpu.usage.total) / 1E9) / sum((endTimestamp - timestamp) / 1000) AS 'CPU usage (cores)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT (sum(container.network.rx_bytes) / sum((endTimestamp - timestamp) / 1000)) + (sum(container.network.tx_bytes) / sum((endTimestamp - timestamp) / 1000)) AS 'Network traffic (bytes per second)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause cannot be used to produce a valid golden metric.

entityBot · 2025-11-18T08:27:17Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 4 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

entityBot · 2025-11-21T10:39:48Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

entityBot · 2025-11-25T08:58:22Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

entityBot · 2025-11-29T08:58:19Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

Let's validate those changes.

entityBot

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT (sum(container.cpu.usage.total) / 1E9) / sum((endTimestamp - timestamp) / 1000) AS 'CPU usage (cores)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

* Error VALIDATING domainType: 'INFRA-CONTAINER' on Golden metrics for key 'SELECT (sum(container.network.rx_bytes) / sum((endTimestamp - timestamp) / 1000)) + (sum(container.network.tx_bytes) / sum((endTimestamp - timestamp) / 1000)) AS 'Network traffic (bytes per second)' FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause cannot be used to produce a valid golden metric.

entityBot · 2025-12-06T11:37:48Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

naxhh · 2025-12-11T10:18:30Z

Please fix the issues

entityBot · 2025-12-14T10:31:03Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

entityBot · 2025-12-18T09:57:45Z

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/EP

Please review or provide an update.

NSSPKrishna and others added 3 commits November 4, 2025 19:28

fix: Dockerstats receiver otel golden-metrics

f61ce0a

Merge branch 'main' into NR-483459

7396f8f

Merge branch 'main' into NR-483459

77ee972

lujop reviewed Nov 4, 2025

View reviewed changes

chore: Summary metrics staging file

937d018

NSSPKrishna force-pushed the NR-483459 branch from eca62cb to 937d018 Compare November 4, 2025 19:10

entityBot previously requested changes Nov 4, 2025

View reviewed changes

entityBot requested a review from a team November 4, 2025 19:11

github-actions bot previously approved these changes Nov 4, 2025

View reviewed changes

bgalmesnr added the waiting on submitter feedback label Nov 5, 2025

Merge branch 'main' into NR-483459

7ceea85

entityBot previously requested changes Nov 5, 2025

View reviewed changes

github-actions bot previously approved these changes Nov 5, 2025

View reviewed changes

chore: Using sum aggregator for the otel queries

1dea3a6

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

NSSPKrishna dismissed github-actions[bot]’s stale review via 1dea3a6 November 13, 2025 15:05

entityBot previously requested changes Nov 13, 2025

View reviewed changes

Merge branch 'main' into NR-483459

6255644

entityBot requested changes Dec 1, 2025

View reviewed changes

github-actions bot approved these changes Dec 1, 2025

View reviewed changes

naxhh removed the waiting on submitter feedback label Dec 3, 2025

naxhh added the waiting on submitter feedback label Dec 11, 2025

fix: Dockerstats receiver otel golden-metrics #2407

Are you sure you want to change the base?

fix: Dockerstats receiver otel golden-metrics #2407

Uh oh!

Conversation

NSSPKrishna commented Nov 4, 2025

Relevant information

Checklist

Uh oh!

lujop left a comment

Choose a reason for hiding this comment

Uh oh!

lujop Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSSPKrishna Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

entityBot left a comment

Choose a reason for hiding this comment

Uh oh!

entityBot left a comment

Choose a reason for hiding this comment

Uh oh!

entityBot commented Nov 8, 2025

Uh oh!

entityBot commented Nov 12, 2025

Uh oh!

entityBot left a comment

Choose a reason for hiding this comment

Uh oh!

entityBot commented Nov 18, 2025

Uh oh!

entityBot commented Nov 21, 2025

Uh oh!

entityBot commented Nov 25, 2025

Uh oh!

entityBot commented Nov 29, 2025

Uh oh!

entityBot left a comment

Choose a reason for hiding this comment

Uh oh!

entityBot commented Dec 6, 2025

Uh oh!

naxhh commented Dec 11, 2025

Uh oh!

entityBot commented Dec 14, 2025

Uh oh!

entityBot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants