-
Notifications
You must be signed in to change notification settings - Fork 363
add segment terms entity #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add segment terms entity #2493
Conversation
|
|
|
|
||
| ownership: | ||
| primaryOwner: | ||
| teamName: "no owner" No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new entity definition please add the owner team. Please check https://pages.datanerd.us/site-engineering/nr-platform-docs/entity-platform/new-entity-type/reviewing-entity-definitions.html#how-ownership-works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team name has been added.
0524770
entityBot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beep boop bop.
I have found some errors processing these changes:
* Error VALIDATING domainType: 'NGEP-SEGMENT_TERMS' on Ownership - Exception: Owner team 'o11y-services' is not among allowed owners.
|
Team need to exist under https://github.com/orgs/newrelic/teams?query=https%3A%2F%2Fgithub.com%2Forgs%2Fnewrelic%2Fteams%3Fquery%3DO11Y_SVCS Please make sure to create the team first |
Let's validate those changes.
entityBot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Could not add the following teams as reviewers because they are not present in newrelic's github org: [O11Y_SVCS]. Please follow instructions to add/create them to org and re-validate PR. Thanks!
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/O11Y_SVCS Please review or provide an update. |
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/O11Y_SVCS Please review or provide an update. |
Relevant information
Add segment terms entity for back sync from NGEP.
Checklist
identifierwill be unique and valid.