Skip to content

Conversation

@kg-nr
Copy link

@kg-nr kg-nr commented Nov 28, 2025

Relevant information

Add segment terms entity for back sync from NGEP.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

entityBot
entityBot previously approved these changes Nov 28, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@entityBot entityBot requested a review from a team November 28, 2025 09:34
entityBot
entityBot previously approved these changes Nov 28, 2025
github-actions[bot]
github-actions bot previously approved these changes Nov 28, 2025
withedgar
withedgar previously approved these changes Dec 1, 2025

ownership:
primaryOwner:
teamName: "no owner" No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team name has been added.

Copy link
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'NGEP-SEGMENT_TERMS' on Ownership - Exception: Owner team 'o11y-services' is not among allowed owners.

@entityBot entityBot requested a review from a team December 4, 2025 09:48
@naxhh
Copy link
Contributor

naxhh commented Dec 9, 2025

Team need to exist under https://github.com/orgs/newrelic/teams?query=https%3A%2F%2Fgithub.com%2Forgs%2Fnewrelic%2Fteams%3Fquery%3DO11Y_SVCS

Please make sure to create the team first

entityBot
entityBot previously approved these changes Dec 9, 2025
@entityBot entityBot dismissed stale reviews from themself December 9, 2025 15:24

Let's validate those changes.

Copy link
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Could not add the following teams as reviewers because they are not present in newrelic's github org: [O11Y_SVCS]. Please follow instructions to add/create them to org and re-validate PR. Thanks!

@kg-nr kg-nr requested a review from entityBot December 11, 2025 07:10
@kg-nr
Copy link
Author

kg-nr commented Dec 11, 2025

@naxhh The team has been created. The entityBot check is still failing.

@entityBot
Copy link
Collaborator

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/O11Y_SVCS

Please review or provide an update.

@entityBot
Copy link
Collaborator

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/O11Y_SVCS

Please review or provide an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants