Skip to content

Mobile Application Ownership #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JustinRush-NR wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Mobile Application Ownership #2513

JustinRush-NR wants to merge 4 commits into from
+3 −1

Conversation

@JustinRush-NR
Copy link
Contributor

@JustinRush-NR JustinRush-NR commented Dec 5, 2025 •
edited
Loading

Relevant information

Take ownership of Mobile Application entities

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

entityBot
entityBot previously requested changes Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'mobile-application' on entitydefinitionemitter.models.BaseEntityDefinition - jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type `ArrayList<entitydefinitionemitter.models.Owner>` from Object value (token `JsonToken.START_OBJECT`)
at [Source: (StringReader); line: 22, column: 5] (through reference chain: entitydefinitionemitter.models.BaseEntityDefinition["ownership"]->entitydefinitionemitter.models.Ownership["secondaryOwners"])

@entityBot entityBot requested a review from a team December 5, 2025 17:33
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@entityBot entityBot dismissed their stale review December 5, 2025 17:38

Let's validate those changes.

entityBot
entityBot previously requested changes Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'MOBILE-APPLICATION' on Ownership - Exception: Owner team 'DEM Platform' is not among allowed owners.

@entityBot entityBot requested review from a team and removed request for a team December 5, 2025 17:38
github-actions[bot]
github-actions bot previously approved these changes Dec 5, 2025
View reviewed changes
naxhh
naxhh previously approved these changes Dec 9, 2025
View reviewed changes
naxhh
naxhh requested changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@naxhh naxhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a dem platform team in teamstore

@naxhh
Copy link
Contributor

naxhh commented Dec 12, 2025

@entityBot check

@entityBot entityBot dismissed stale reviews from github-actions[bot] and themself December 12, 2025 09:20

Let's validate those changes.

entityBot
entityBot previously requested changes Dec 12, 2025
View reviewed changes
Copy link
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'MOBILE-APPLICATION' on Ownership - Exception: Owner team 'DEM Platform' is not among allowed owners.

@entityBot
Copy link
Collaborator

entityBot commented Dec 16, 2025

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 4 days and is still awaiting approval from: @newrelic/MOBAGENT

Please review or provide an update.

@entityBot entityBot dismissed stale reviews from naxhh and themself December 16, 2025 15:30

Dismissing reviews

entityBot
entityBot requested changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'MOBILE-APPLICATION' on Ownership - Exception: Owner team 'MOBAGENT' is not among allowed owners.

* Error VALIDATING domainType: 'MOBILE-APPLICATION' on Ownership - Exception: Owner team 'DEMPLA' is not among allowed owners.

@entityBot entityBot requested review from a team and removed request for a team December 16, 2025 15:30
@JustinRush-NR
Copy link
Contributor Author

JustinRush-NR commented Dec 16, 2025

@naxhh I have updated with the correct Teamstore names, but still getting errors. Can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naxhh naxhh naxhh requested changes

@entityBot entityBot entityBot requested changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

waiting on submitter feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JustinRush-NR @CLAassistant @naxhh @entityBot