Skip to content

HTTP header field names should be case insensitive #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lu4p wants to merge 1 commit into from
Closed

HTTP header field names should be case insensitive #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/src/main/java/com/nextcloud/android/sso/api/Headers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.nextcloud.android.sso.api;

import androidx.annotation.NonNull;

import java.util.HashMap;
import java.util.Map;

public class Headers {
private final Map<String, String> headers = new HashMap<>();

public void put(String key, String value) {
headers.put(key.toLowerCase(), value);
}

public String get(String key) {
return headers.get(key.toLowerCase());
}
}
8 changes: 3 additions & 5 deletions lib/src/main/java/com/nextcloud/android/sso/api/ParsedResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,10 @@
import androidx.annotation.Nullable;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.Map;

public class ParsedResponse<T> {
private final T response;
private final Map<String, String> headers = new HashMap<>();
private final Headers headers = new Headers();

public ParsedResponse(T response, @Nullable ArrayList<AidlNetworkRequest.PlainHeader> headers) {
this.response = response;
Expand All @@ -39,7 +37,7 @@ public T getResponse() {
return response;
}

public Map<String, String> getHeaders() {
public Headers getHeaders() {
return headers;
}
}
}