feat: exchange cloud ID

[redblom]

This is a work in progress
This PR implements #4416

[redblom]

General layout plan:

• dedicated button to send an invite to a remote user - below 'New contact' button
• dedicated button on cloud ID component for existing remote contacts that have no cloud ID set
• new sent invites will be displayed in the left panel - with a revoke option

Status:

• invite accept dialog route implemented

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[codecov]

Codecov Report

❌ Patch coverage is 1.10865% with 446 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.84%. Comparing base (c98a2da) to head (5b7820f).

Files with missing lines	Patch %	Lines
src/views/Contacts.vue	0.00%	90 Missing ⚠️
src/components/Properties/PropertyCloudId.vue	0.00%	72 Missing ⚠️
src/components/Ocm/OcmInvitesList.vue	0.00%	53 Missing ⚠️
src/components/Ocm/Wayf.vue	0.00%	44 Missing ⚠️
src/store/ocminvites.js	10.41%	42 Missing and 1 partial ⚠️
src/components/Ocm/OcmInviteDetails.vue	0.00%	41 Missing ⚠️
src/components/AppContent/OcmInvitesContent.vue	0.00%	33 Missing ⚠️
src/components/Ocm/OcmInviteForm.vue	0.00%	18 Missing ⚠️
src/components/AppNavigation/RootNavigation.vue	0.00%	14 Missing ⚠️
src/components/Ocm/OcmInvitesListItem.vue	0.00%	13 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (c98a2da) and HEAD (5b7820f). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (c98a2da)	HEAD (5b7820f)
	2	1

Additional details and impacted files

@@             Coverage Diff             @@
##               main   #4417      +/-   ##
===========================================
- Coverage     10.76%   1.84%   -8.93%     
===========================================
  Files           128     113      -15     
  Lines          6512    6082     -430     
  Branches       1191    1270      +79     
===========================================
- Hits            701     112     -589     
- Misses         5690    5847     +157     
- Partials        121     123       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ChristophWurst]

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

[redblom]

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

Short answer: No, that is to say, the actual cloud ID exchange is not a responsibility of the contacts app but the contacts app (the cloud ID field) is a logical place where to have this option (as per earlier discussion with the Design Team).
The feature actually depends on the implementation of OCM /invite-accepted. This is currently in the process of being implemented for nextcloud server core (nextcloud/server#51113) so cloud ID exchange can become an integral part of nextcloud. Up until then there should be an app present implementing this.
The idea is to make the option not visible to the user when the platform can not do the actual cloud ID exchange (by configuration).
(so the best answer is: yes, when cloud ID exchange has become an integral part of nextcloud :)

[ChristophWurst]

Thanks for the clarification

[redblom]

Do we want to 'cc' the invitation email to the sender as well (by default or configurable) ?
Eg. in case the receiver loses the invitation mail it would allow the sender to simply resend the invitation from the email client instead of having to create a new one (and revoke the old one) from the contacts app.
* Another (possible future) option would be a resend button on the invitation details page.

[mickenordin]

Do we want to 'cc' the invitation email to the sender as well (by default or configurable) ? Eg. in case the receiver loses the invitation mail it would allow the sender to simply resend the invitation from the email client instead of having to create a new one (and revoke the old one) from the contacts app. * Another (possible future) option would be a resend button on the invitation details page.

I think a "resend button" makes sense, maybe along with a check box that is unchecked by default to send the invitation to the sender as well.

[redblom]

Do we want to 'cc' the invitation email to the sender as well (by default or configurable) ? Eg. in case the receiver loses the invitation mail it would allow the sender to simply resend the invitation from the email client instead of having to create a new one (and revoke the old one) from the contacts app. * Another (possible future) option would be a resend button on the invitation details page.

I think a "resend button" makes sense, maybe along with a check box that is unchecked by default to send the invitation to the sender as well.

We do not persist the optional personal message with the invite. So that's lost for a resend. But in order to correlate to the previously sent invite, what we can do is to use a new message like:
"This is a copy of an invite send to you previously by $initiatorDisplayName on $sendDate"

Fwiw I prefer this to persisting the message.

[mickenordin]

Adding some screenshots here to show you what it looks like, this is the dialog for adding a new invitation:

This is what it looks like after it is sent:

This is the default Where-Are-You-From page, when no federation has been configured

This is what the WAYF-page looks like with a federation configured:

It is also possible to add multiple federations:

This is what the type-to-search feature looks like:

[mickenordin]

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

All the necessary plumbing is in Nextcloud 32.0.0.0rc4 so no external apps needed anymore.

[redblom]

@ArtificialOwl could you give it a go, the review.