Skip to content

Conversation

@GVodyanov
Copy link
Contributor

Fix #4601

@GVodyanov GVodyanov self-assigned this Oct 6, 2025
@GVodyanov GVodyanov added the 2. developing Work in progress label Oct 6, 2025
…nging addressbook

Signed-off-by: Grigory Vodyanov <[email protected]>

# Conflicts:
#	src/components/ContactsList.vue
#	src/components/ContactsList/ContactsListItem.vue
@GVodyanov GVodyanov force-pushed the feat/add-batch-grouping-and-addressbook-change branch from 111b779 to 0aa3d50 Compare October 27, 2025 09:57
@GVodyanov GVodyanov marked this pull request as ready for review October 27, 2025 09:58
@GVodyanov GVodyanov requested a review from hamza221 as a code owner October 27, 2025 09:58
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.85%. Comparing base (96b9484) to head (0aa3d50).

Files with missing lines Patch % Lines
src/components/ContactsList/Batch.vue 0.00% 90 Missing ⚠️
src/components/ContactsList.vue 0.00% 23 Missing ⚠️
src/components/ContactsList/ContactsListItem.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4761      +/-   ##
============================================
- Coverage     11.07%   10.85%   -0.22%     
  Complexity      293      293              
============================================
  Files           127      128       +1     
  Lines          6546     6676     +130     
  Branches       1191     1236      +45     
============================================
  Hits            725      725              
- Misses         5699     5829     +130     
  Partials        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski
Copy link
Contributor

Tested works. But I found some glitches

A) it seems you are checking the source address book for canModify, but should be checking it for canDestory, as a move operation deletes contacts from the source and canCreate in the destiantion

Moving contacts from recents
image

B) after clicking "move" the contacts app remains in multi-select mode

After moving contacts
image

@SebastianKrupinski
Copy link
Contributor

Not sure if you have seen the new acls

#4728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch actions for adding to group and moving from one address book to another

3 participants