Skip to content

Conversation

@GVodyanov
Copy link
Contributor

The selecting wasn't working

@GVodyanov GVodyanov self-assigned this Oct 19, 2025
@GVodyanov GVodyanov requested a review from hamza221 as a code owner October 19, 2025 20:03
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Oct 19, 2025
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.04%. Comparing base (66e1d5e) to head (a66bc1e).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...ts/AppNavigation/Settings/SettingsSortContacts.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4804   +/-   ##
=========================================
  Coverage     11.04%   11.04%           
  Complexity      293      293           
=========================================
  Files           127      127           
  Lines          6565     6563    -2     
  Branches       1204     1205    +1     
=========================================
  Hits            725      725           
+ Misses         5718     5716    -2     
  Partials        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GVodyanov
Copy link
Contributor Author

/backport to stable8.0

@GVodyanov GVodyanov force-pushed the fix/sorting-contacts-ncselect branch from 51c3e45 to a66bc1e Compare October 19, 2025 20:10
@SebastianKrupinski
Copy link
Contributor

Tested. But there is a bug.

image
  • Select a sort order
  • Then save and close the settings modal
  • Re-open the settings modal

The key is show and not the option label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants