fix(log): support nginx built without variadic macros #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bavshin-f5
force-pushed
the
logs-no-variadic
branch
from
679b5d1 to
7635440
Compare
xeioex
approved these changes
Jan 16, 2025
Fixed the error below, caused by a different signature of
`ngx_log_error_core` when neither `NGX_HAVE_C99_VARIADIC_MACROS` nor
nor `NGX_HAVE_GCC_VARIADIC_MACROS` is detected.
An example of affected configuration is MinGW with clang or gcc, where
we skip most of the compiler feature checks.
```
error[E0061]: this function takes 5 arguments but 6 arguments were
supplied
--> examples\awssig.rs:312:9
|
312 | ngx_log_debug_http!(request, "headers {:?}", headers);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unexpected argument nginx#6 of type `*const u8`
|
note: expected `*mut i8`, found `usize`
```
bavshin-f5
force-pushed
the
logs-no-variadic
branch
from
7635440 to
8137546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the error below, caused by a different signature of
ngx_log_error_corewhen neitherNGX_HAVE_C99_VARIADIC_MACROSnor norNGX_HAVE_GCC_VARIADIC_MACROSis detected.An example of affected configuration is MinGW with clang or gcc, where we skip most of the compiler feature checks.