Skip to content

Apply the ESLint configuration specific rules using globs. #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrevorKarjanis merged 2 commits into from
Nov 26, 2025
Merged

Apply the ESLint configuration specific rules using globs. #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a46370
Apply the ESLint configuration specific rules using globs.
TrevorKarjanis Nov 26, 2025
d2ed1af
Change files
TrevorKarjanis Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-eslint-config-javascript-e6539dad-548c-4657-bca2-33de59be8022.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Apply the ESLint configuration specific rules using globs.",
"packageName": "@ni/eslint-config-javascript",
"email": "[email protected]",
"dependentChangeType": "patch"
}
6 changes: 3 additions & 3 deletions packages/eslint-config-javascript/lib/imports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,12 +387,12 @@ export const imports = defineConfig([{
}
}, {
/*
Eslint configuration file specific settings
ESLint configuration file specific settings
*/
files: ['eslint.config.js', 'eslint.config.mjs'],
files: ['**/eslint.config.js', '**/eslint.config.mjs'],
extends: [importNodeEsmConfig],
rules: {
// eslint config files require a top-level default export
'import/no-default-export': 'off',
'import/no-default-export': 'off'
}
}]);