-
Notifications
You must be signed in to change notification settings - Fork 11
Test with an Angular workspace in the Angular smoke test. #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
820b0d3 to
f7b9363
Compare
rajsite
reviewed
Nov 26, 2025
Member
rajsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have a more representative smoke test! 👍
f7b9363 to
027a3d3
Compare
rajsite
reviewed
Nov 26, 2025
rajsite
approved these changes
Nov 26, 2025
rajsite
reviewed
Nov 26, 2025
rajsite
reviewed
Nov 26, 2025
rajsite
reviewed
Nov 26, 2025
027a3d3 to
efa3bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #177. Test with an Angular workspace to validate that the style guide configuration works with the workspace configuration, root applications, libraries, language and parser options, ng lint, and the standalone eslint command. This also validates the instructions provided in the README. The original ignore custom attributes test has been integrated into the root application component template. Additionally, there is a root component test with HTML file and library component test with inline template.
The workspace has been reduced to the necessities of a test which satisfies the criteria.
Testing