Skip to content

Conversation

@shilpanice
Copy link
Contributor

>
<Radio
hint="Some helpful hint text"
label="Yes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep casing consistent across value attributes.

if we keep to lower casing, that keeps those consistent across pair react and html examples
e.g. value="yes" instead of value="Yes"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to check across examples and amend where needed.

Copy link
Contributor

@dalecreativ dalecreativ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to action, mainly around code example blocks.
Give me nudge if needed

-Updated examples with unique form group names
-changed value to lowercase
@dalecreativ
Copy link
Contributor

Because we've dound a potential issue in the FormGroup handling of name prop, we might need to revert back to the FormGroup carrying the name and remove name from nested controls. Sorry @shilpanice

-Removed name attribute from individual radios
dalecreativ
dalecreativ previously approved these changes Dec 11, 2025
@shilpanice
Copy link
Contributor Author

Because we've dound a potential issue in the FormGroup handling of name prop, we might need to revert back to the FormGroup carrying the name and remove name from nested controls. Sorry @shilpanice

No worries Dale...ALl updated now!! Thank you

beccadawson
beccadawson previously approved these changes Dec 15, 2025
beccadawson
beccadawson previously approved these changes Dec 15, 2025
@lizaadebowale lizaadebowale merged commit 875e702 into main Jan 8, 2026
@lizaadebowale lizaadebowale deleted the NDS-493-update-radio-button-documentation branch January 8, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants