-
Notifications
You must be signed in to change notification settings - Fork 9
NDS-493 update radio button documentation #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/pages/components/radio.mdx
Outdated
| > | ||
| <Radio | ||
| hint="Some helpful hint text" | ||
| label="Yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep casing consistent across value attributes.
if we keep to lower casing, that keeps those consistent across pair react and html examples
e.g. value="yes" instead of value="Yes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to check across examples and amend where needed.
dalecreativ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments to action, mainly around code example blocks.
Give me nudge if needed
-Updated examples with unique form group names -changed value to lowercase
|
Because we've dound a potential issue in the FormGroup handling of name prop, we might need to revert back to the FormGroup carrying the name and remove name from nested controls. Sorry @shilpanice |
-Removed name attribute from individual radios
No worries Dale...ALl updated now!! Thank you |
https://nicedigital.atlassian.net/browse/NDS-493