lib/milenage: use Cryptodome instead of Crypto #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyCryptodome modules are available in Crypto for legacy compatibility with the old PyCrypto library, and in Cryptodome. Switch to the non-legacy name, so the Debian 12 package python3-pycryptodome can be used (there is no python3-pycrypto package in Debian anymore).
|
LGTM! |
Collaborator
|
Looks innocent enough but: It could break installations without re-running @nickvsnetworking Since pyHss aims to follow a SemVer scheme: An in-place upgrade that might fail due to changed dependency APIs would be a breaking change IMHO. So this should land in a 2.0 release and be documented somewhere. Maybe in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCryptodome modules are available in Crypto for legacy compatibility with the old PyCrypto library, and in Cryptodome. Switch to the non-legacy name, so the Debian 12 package python3-pycryptodome can be used (there is no python3-pycrypto package in Debian anymore).
See also: