change param name to avoid CUDA solvers runtime error: "nonLinearIter… #150
+27
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations" -> "nIterations", "linearIterations" -> "lIterations"
Collaborator
|
Happy to merge the first 3 commits; but the last two seem to be one-off tests. |
Author
|
Thanks for your reply~ I don't quite understand the words one-off tests (not use the PR quite often...), could u explain it a bit? Does that mean I should close this PR and create another one which contains only the first 3 commits? BTW, I have one more question on the Thank you very much~~~~ :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ations" -> "nIterations", "linearIterations" -> "lIterations"
since this commit: f96f626#diff-4ec1b09480d2efd4ac57e2db04ec1bdd
the param names have been changed in
examples/shape_from_shading/src/CombinedSolver.h