Next step require #414
Open
Next step require #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksanb
force-pushed
the
next-step-require
branch
2 times, most recently
from
383aaee to
76bd21d
Compare
Member
|
needs rebase |
This keeps the namespace and import tree clean, as single files with just one class definition like TextureInput and TextureOutput were a bit overkill.
aleksanb
force-pushed
the
next-step-require
branch
from
76bd21d to
028f1f5
Compare
Member
|
Why is the closure compiler commented out for the time being? I also did a small comment on e934b92 , and the question here is what are you guys doing and how can I track it? There's no issues or discussions on what has been done I believe, so it's hard for me to contribute right now. |
aleksanb
force-pushed
the
next-step-require
branch
from
028f1f5 to
6c33182
Compare
If they are needed, they can be re-added manually to each demo project's lib folder. This slims down bootstrap.js and makes my task of requiring up bootstrap.js easier. They're not used in the demo 're', so we don't have to maintain any potential backwards compatability.
Member
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.