Feature/add aspire #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created 01-init-db.sh to initialize the contacts database if it doesn't exist. - Added 02-seed-data.sql to create necessary tables and insert initial data including users, roles, permissions, and sample contacts. - Implemented foreign key constraints and unique constraints for data integrity. - Seeded initial roles (Admin, Reader, Editor) and assigned permissions accordingly.
…image to 17-alpine and add pgAdmin service to docker-compose.
…mponents - Bump Angular and related dependencies to version 21.0.1 - Update Express to version 4.21.0 - Update TypeScript to version 5.9.0 - Update Tailwind CSS and PostCSS dependencies - Refactor HostListener decorators in HeaderComponent and LayoutComponent to remove unused event parameters - Add Fluent 2 Design System tokens and utility classes to Tailwind CSS for consistent styling
…odels and validators; update frontend technology descriptions
- Refactor role-permission mapping component to use ChangeDetectionStrategy.OnPush for better performance. - Update roles component to include loading indicators and improved error handling. - Revamp user roles management UI with a new layout and enhanced user experience. - Implement confirmation dialogs for user and role deletions to prevent accidental actions. - Improve user management interface with better form validation and user feedback. - Add skeleton loading states for better UX during data fetching.
There was a problem hiding this comment.
Pull request overview
This pull request adds .NET Aspire support to enable cloud-ready orchestration for local development, along with significant technology stack updates and UI enhancements.
Key Changes
- Aspire Integration: Added .NET Aspire 9.5 for service orchestration, discovery, and observability with an integrated dashboard
- Version Upgrades: Updated to Angular 21, .NET 10, PostgreSQL 17, and TailwindCSS v4
- Design System: Integrated Microsoft Fluent Design System 2 tokens and styling
Reviewed changes
Copilot reviewed 67 out of 224 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/02-seed-data.sql |
Comprehensive database seed script with tables, permissions, roles, and sample data |
scripts/01-init-db.sh |
PostgreSQL database initialization script for Docker |
frontend/src/app/styles/tailwind.css |
Added Fluent Design System tokens (colors, shadows, typography, motion) |
frontend/src/app/feature/user/home/home.component.ts |
Updated technology descriptions to reflect version changes |
frontend/src/app/feature/admin/*/ |
Enhanced admin components with Material 3, OnPush detection, and new reusable components |
frontend/src/app/@core/components/*/ |
New reusable components (PageHeader, EmptyState, Skeleton, ConfirmDialog) |
frontend/proxy.conf.js |
New Aspire-aware proxy configuration with environment variable support |
frontend/package.json |
Updated to Angular 21.0.1, Material 21, and supporting dependencies |
backend/Contact.Domain/Entities/ContactPerson.cs |
Changed DateOfBirth from DateTime to DateOnly |
backend/Contact.Infrastructure/*/ |
Complete repository implementations with Dapper and PostgreSQL |
backend/*/Contact.*.csproj |
Updated target framework to net10.0 |
docker-compose.yml |
Added pgAdmin service and updated PostgreSQL to version 17 |
docs/* |
Updated documentation for Aspire, Angular 21, .NET 10, and new features |
Comments suppressed due to low confidence (1)
backend/Contact.Domain/Entities/ContactPerson.cs:7
- Changing
DateOfBirthfromDateTimetoDateOnlyis a breaking API change. WhileDateOnlyis more appropriate for birth dates (as it doesn't include time information), this will break existing clients expecting aDateTime. Consider providing a migration path or documenting this breaking change clearly.
Comment on lines
+4
to
+6
| target: process.env['services__contact-api__https__0'] || | ||
| process.env['services__contact-api__http__0'] || | ||
| 'http://localhost:5217', |
There was a problem hiding this comment.
The proxy configuration reads Aspire-injected environment variables (services__contact-api__https__0, services__contact-api__http__0) with a fallback to localhost. However, the environment variable names use double underscores which might be transformed differently by different shells. Consider documenting this Aspire-specific configuration or using a more robust environment variable naming strategy.
Comment on lines
+26
to
+31
| var frontend = builder.AddNpmApp("frontend", "../../frontend", "serve") | ||
| .WithReference(api) | ||
| .WaitFor(api) | ||
| .WithHttpEndpoint(targetPort: 4200, env: "PORT") | ||
| .WithExternalHttpEndpoints() | ||
| .PublishAsDockerFile(); |
Comment on lines
+1
to
+6
| import { | ||
| Component, | ||
| ChangeDetectionStrategy, | ||
| input, | ||
| output, | ||
| } from '@angular/core'; |
There was a problem hiding this comment.
Unused import output.
| @@ -1,13 +1,16 @@ | |||
| import { Component, ViewChild, AfterViewInit, signal, computed, effect, inject, OnInit } from '@angular/core'; | |||
| import { Component, ViewChild, AfterViewInit, signal, computed, effect, inject, OnInit, ChangeDetectionStrategy } from '@angular/core'; | |||
There was a problem hiding this comment.
Unused import computed.
| import { MatButtonModule } from '@angular/material/button'; | ||
| import { MatIconModule } from '@angular/material/icon'; | ||
| import { MatCardModule } from '@angular/material/card'; | ||
| import { DatePipe, NgFor, NgIf, CommonModule } from '@angular/common'; |
There was a problem hiding this comment.
Unused imports NgFor, NgIf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.