Skip to content

Avoid most approval subtractions #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Avoid most approval subtractions #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/label_approved/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,19 @@ def process_pr(g_h: Github, p_r_object: PrWithGraphQL) -> None:
approved_users.discard(reviewed_user)

old_labels: set[str] = p_r_object.get_labels() & set(label_dict.values())
old_approval_count = 0
for i in range(1, max(label_dict.keys()) + 1):
if label_dict[i] in old_labels:
old_approval_count = i

labels: set[str] = set()
approval_count = min(len(approved_users), max(label_dict.keys()))

# if the old approval count is at least the same as the new one,
# we consider the labels to be up-to-date, and we skip the PR
if old_approval_count >= approval_count:
return

if last_approved_review_date is not None:
last_commit_date = p_r_object.get_last_commit_date()
# if there are no commits, the PR is closed; no need to update labels
Expand Down