fix: parse $EDITOR arguments #303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobe4
reviewed
Jan 9, 2026
Owner
|
Thanks for this! It looks simple enough 🙏 Kudos for reusing a dependency of the project so we don't need to import something else 🧹 |
Added a //nolint:gosec comment to suppress security linter warnings for using the $EDITOR environment variable, as its usage is explicitly trusted in this context. Co-Authored-By: nobe4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how the user's configured editor is invoked when editing the config file, ensuring that complex
$EDITORvalues (such as those with arguments or spaces) are handled correctly. It does this by using theshlexlibrary to safely parse the editor command. Fixes #302.