-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
util: limit inspect to only show own properties #61032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BridgeAR
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
BridgeAR:BridgeAR/2025-12-12-only-inspect-own-properties
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
util: limit inspect to only show own properties #61032
BridgeAR
wants to merge
2
commits into
nodejs:main
from
BridgeAR:BridgeAR/2025-12-12-only-inspect-own-properties
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61032 +/- ##
==========================================
- Coverage 88.52% 88.51% -0.01%
==========================================
Files 703 703
Lines 208538 208546 +8
Branches 40214 40219 +5
==========================================
- Hits 184615 184604 -11
- Misses 15921 15968 +47
+ Partials 8002 7974 -28
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Dec 12, 2025
aduh95
reviewed
Dec 12, 2025
Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling. Fixes: nodejs#60717 Closes: nodejs#60724
e0f773f to
29620d2
Compare
aduh95
reviewed
Dec 15, 2025
aduh95
approved these changes
Dec 15, 2025
aduh95
approved these changes
Dec 15, 2025
ljharb
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assert
Issues and PRs related to the assert subsystem.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
console
Issues and PRs related to the console subsystem.
needs-ci
PRs that need a full CI run.
request-ci
Add this label to start a Jenkins CI on a PR.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling.
As drive-by I changed an array to a set for faster lookup in assert.
Fixes: #60717
Closes: #60724