Skip to content

Conversation

@BridgeAR
Copy link
Member

Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling.

As drive-by I changed an array to a set for faster lookup in assert.

Fixes: #60717
Closes: #60724

@BridgeAR BridgeAR added util Issues and PRs related to the built-in util module. console Issues and PRs related to the console subsystem. labels Dec 12, 2025
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (14f02fc) to head (eee56d6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61032      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.01%     
==========================================
  Files         703      703              
  Lines      208538   208546       +8     
  Branches    40214    40219       +5     
==========================================
- Hits       184615   184604      -11     
- Misses      15921    15968      +47     
+ Partials     8002     7974      -28     
Files with missing lines Coverage Δ
lib/internal/util/inspect.js 99.63% <100.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 12, 2025
Error's cause and errors properties would be visible even if these
were not own properties. This is changed to align with all other
parts of the inspect handling.

Fixes: nodejs#60717
Closes: nodejs#60724
@BridgeAR BridgeAR force-pushed the BridgeAR/2025-12-12-only-inspect-own-properties branch from e0f773f to 29620d2 Compare December 15, 2025 11:50
@BridgeAR BridgeAR requested review from aduh95 and ljharb December 15, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

util.inspect throws when given a ZodError

4 participants