http2: tune control flow defaults #61036
Open
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Member
Author
|
I'm unsure about the relationship between request window size (initialWindowSize) and connection window size (connectionWindowSize). But I assume it's ok to have a 1:2 relationship. 🤷 |
Member
Author
|
This affects UPLOAD speed, i.e. data to server. |
ronag
commented
Dec 12, 2025
| this.emit('session', session); | ||
| } | ||
|
|
||
| function initializeOptions(options) { | ||
| assertIsObject(options, 'options'); | ||
| options = { ...options }; | ||
| options = { ...getDefaultSettings(), ...options }; |
Member
Author
There was a problem hiding this comment.
We should actually apply the default settings and not just assume that they are the same as nghttp2 will do.
ronag
force-pushed
the
http2-tune
branch
2 times, most recently
from
f6732e4 to
eae93cc
Compare
The current defaults are unnecessarily conservative which makes http2 control flow over high latency connections (such as public internet) unbearably slow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61036 +/- ##
==========================================
- Coverage 88.58% 88.49% -0.10%
==========================================
Files 704 703 -1
Lines 207815 208557 +742
Branches 40036 40198 +162
==========================================
+ Hits 184102 184571 +469
- Misses 15758 16019 +261
- Partials 7955 7967 +12
🚀 New features to boost your workflow:
|
mcollina
approved these changes
Dec 13, 2025
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm
I think this might require a doc change too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current defaults are unnecessarily conservative which makes http2 control flow over high latency connections (such as public internet) unbearably slow.