-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
build,deps: replace cjs-module-lexer with merve #61456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anonrig
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
anonrig:yagiz/experiment-with-cjs-lexer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,175
−8,561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
ae6ab98 to
5e69495
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61456 +/- ##
========================================
Coverage 89.85% 89.86%
========================================
Files 671 672 +1
Lines 203166 203322 +156
Branches 39057 39085 +28
========================================
+ Hits 182554 182713 +159
+ Misses 12967 12940 -27
- Partials 7645 7669 +24
🚀 New features to boost your workflow:
|
9bfb358 to
1da16dd
Compare
66e99b4 to
d687c0a
Compare
Member
|
Where does this new dep live? |
Member
Author
Currently, under my github account. Is anybody interested in helping me maintain it? github.com/anonrig/merve |
richardlau
reviewed
Jan 22, 2026
d687c0a to
b2ec704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially started a couple of years ago, the new cjs module lexer is 25% faster for cold importing cjs files. This change introduces a new dependency and removes the old one.
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1784/console