cmake build improvements #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing GMP targets when find_package(greenX) is called - Namespace the include directory for the fortran modules
moritzleucke
approved these changes
May 23, 2025
fdelesma
approved these changes
May 23, 2025
Contributor
fdelesma
left a comment
fdelesma
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of it.
Author
|
No problem. Thank for merging it. If an issue about cmake comes by, please forward it to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various improvements to the cmake build system.
GMPtargets whenfind_package(greenX)is calledincludedirectory for thefortranmodulesgreenXconfig.cmakefile