scripts: board gen: Default to nrfutil and align with upstream #25572

carlescufi · 2025-11-13T15:35:13Z

Default to nrfutil on all boards and also add some changes made upstream in the meantime.

Default to nrfutil on all boards and also add some changes made upstream in the meantime. Signed-off-by: Carles Cufi <[email protected]>

carlescufi · 2025-11-13T15:35:28Z

@nordicjm could you review this one please?

Copilot

Pull Request Overview

This pull request updates board generation templates to default to nrfutil and incorporates upstream changes. The main objective is to prioritize nrfutil as the default board runner across all nRF SoC families.

Key changes:

Reordered board runner includes to prioritize nrfutil over nrfjprog
Added TFM configuration blocks for nrf54l boards
Added nrfutil-specific external memory configuration arguments for nrf52 and nrf53 boards

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
scripts/west_commands/create_board/templates/nrf91/board.cmake.jinja2	Adds nrfutil include before nrfjprog to prioritize nrfutil as default runner
scripts/west_commands/create_board/templates/nrf54l/board.cmake.jinja2	Adds TFM configuration blocks and includes nrfutil as the primary runner
scripts/west_commands/create_board/templates/nrf53/board.cmake.jinja2	Adds nrfutil external memory config and reorders includes to prioritize nrfutil
scripts/west_commands/create_board/templates/nrf52/board.cmake.jinja2	Adds nrfutil external memory config for QSPI and reorders includes to prioritize nrfutil

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-13T15:39:13Z

scripts/west_commands/create_board/templates/nrf54l/board.cmake.jinja2

+endif()
+
+if(CONFIG_TFM_FLASH_MERGED_BINARY)
+  set_property(TARGET runners_yaml_props_target PROPERTY hex_file "${CMAKE_BINARY_DIR}/tfm_merged.hex")


The hex_file path should use tfm_merged.hex instead of "${CMAKE_BINARY_DIR}/tfm_merged.hex" to be consistent with existing boards. All other boards in the repository (nrf54lv10dk, nrf7120pdk, tpm530mevk) use just tfm_merged.hex without the CMAKE_BINARY_DIR prefix.

Suggested change

set_property(TARGET runners_yaml_props_target PROPERTY hex_file "${CMAKE_BINARY_DIR}/tfm_merged.hex")

set_property(TARGET runners_yaml_props_target PROPERTY hex_file "tfm_merged.hex")

Copilot · 2025-11-13T15:39:14Z

scripts/west_commands/create_board/templates/nrf53/board.cmake.jinja2

 endif()

 if(CONFIG_BOARD_{{ board | upper }}_NRF5340_CPUAPP OR CONFIG_BOARD_{{ board | upper }}_NRF5340_CPUAPP_NS)
+  board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/nrf5340dk_qspi_nrfutil_config.json")


The config file path contains a hardcoded board name "nrf5340dk" which will be incorrect for boards generated from this template. This should either use a template variable like {{ board }} or be removed if there's no generic way to handle this configuration.

Suggested change

board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/nrf5340dk_qspi_nrfutil_config.json")

board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/{{ board }}_qspi_nrfutil_config.json")

Copilot · 2025-11-13T15:39:14Z

scripts/west_commands/create_board/templates/nrf52/board.cmake.jinja2

@@ -1,10 +1,13 @@
-board_runner_args(jlink "--device={{ soc | replace("nrf", "nRF") }}_xx{{ variant[2:] | upper }}" "--speed=4000")
+if(CONFIG_SOC_NRF52840_QIAA)
+  board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/nrf52840dk_qspi_nrfutil_config.json")


The config file path contains a hardcoded board name "nrf52840dk" which will be incorrect for boards generated from this template. This should either use a template variable like {{ board }} or be removed if there's no generic way to handle this configuration.

Suggested change

board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/nrf52840dk_qspi_nrfutil_config.json")

board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/{{ board }}_qspi_nrfutil_config.json")

NordicBuilder · 2025-11-13T15:40:41Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 6d0ab2deac3ef97bce4086d9a2e1c09402f41e9b

more details

sdk-nrf:

PR head: 6d0ab2deac3ef97bce4086d9a2e1c09402f41e9b
merge base: 9022759eb4627eb67ccbc8465c2305e11f9fb78e
target head (main): 31417239e6281319c64218bec52ee98075475420
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (5)

scripts
│  ├── requirements-fixed.txt
│  ├── west_commands
│  │  ├── create_board
│  │  │  ├── templates
│  │  │  │  ├── nrf52
│  │  │  │  │  │ board.cmake.jinja2
│  │  │  │  ├── nrf53
│  │  │  │  │  │ board.cmake.jinja2
│  │  │  │  ├── nrf54l
│  │  │  │  │  │ board.cmake.jinja2
│  │  │  │  ├── nrf91
│  │  │  │  │  │ board.cmake.jinja2

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

❌ Toolchain
❌ Build twister
❌ Integration tests
- ❌ test-fw-nrfconnect-ble_mesh

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

nordicjm · 2025-11-14T07:22:58Z

scripts/west_commands/create_board/templates/nrf52/board.cmake.jinja2

@@ -1,10 +1,13 @@
-board_runner_args(jlink "--device={{ soc | replace("nrf", "nRF") }}_xx{{ variant[2:] | upper }}" "--speed=4000")
+if(CONFIG_SOC_NRF52840_QIAA)


this should only be present if the soc is nrf52840, not as in "if(CONFIG..." in the output file but just the one line if soc == nrf52840. Also this depends on if they have QSPI set up or even wired in...

nordicjm · 2025-11-14T07:23:50Z

scripts/west_commands/create_board/templates/nrf53/board.cmake.jinja2

 endif()

 if(CONFIG_BOARD_{{ board | upper }}_NRF5340_CPUAPP OR CONFIG_BOARD_{{ board | upper }}_NRF5340_CPUAPP_NS)
+  board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/nrf5340dk_qspi_nrfutil_config.json")


this too, a board might not have QSPI flash at all, or if it does it might have a very different configuration, on different pins, different mode, etc. plus I don't see this file even here?

The current version has a vulnerability: GHSA-f83h-ghpp-7wcc update to 20251107. Signed-off-by: Carles Cufi <[email protected]>

scripts: board gen: Default to nrfutil and align with upstream

76d78c4

Default to nrfutil on all boards and also add some changes made upstream in the meantime. Signed-off-by: Carles Cufi <[email protected]>

Copilot AI review requested due to automatic review settings November 13, 2025 15:35

carlescufi requested a review from gmarull as a code owner November 13, 2025 15:35

NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 13, 2025

Copilot started reviewing on behalf of carlescufi November 13, 2025 15:35 View session

carlescufi requested review from anangl, bjarki-andreasen and nordicjm November 13, 2025 15:35

Copilot finished reviewing on behalf of carlescufi November 13, 2025 15:38

Copilot AI reviewed Nov 13, 2025

View reviewed changes

nordicjm requested changes Nov 14, 2025

View reviewed changes

scripts: requirements: Bump the version of pdfminer.six

6d0ab2d

The current version has a vulnerability: GHSA-f83h-ghpp-7wcc update to 20251107. Signed-off-by: Carles Cufi <[email protected]>

carlescufi requested review from a team as code owners November 14, 2025 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

scripts: board gen: Default to nrfutil and align with upstream #25572

scripts: board gen: Default to nrfutil and align with upstream #25572

carlescufi commented Nov 13, 2025

Uh oh!

carlescufi commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 13, 2025

Uh oh!

Copilot AI Nov 13, 2025

Uh oh!

Copilot AI Nov 13, 2025

Uh oh!

NordicBuilder commented Nov 13, 2025 •

edited

Loading

Uh oh!

nordicjm Nov 14, 2025

Uh oh!

nordicjm Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	set_property(TARGET runners_yaml_props_target PROPERTY hex_file "${CMAKE_BINARY_DIR}/tfm_merged.hex")
	set_property(TARGET runners_yaml_props_target PROPERTY hex_file "tfm_merged.hex")

	board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/nrf5340dk_qspi_nrfutil_config.json")
	board_runner_args(nrfutil "--ext-mem-config-file=${BOARD_DIR}/support/{{ board }}_qspi_nrfutil_config.json")

		@@ -1,10 +1,13 @@
		board_runner_args(jlink "--device={{ soc \| replace("nrf", "nRF") }}_xx{{ variant[2:] \| upper }}" "--speed=4000")
		if(CONFIG_SOC_NRF52840_QIAA)

scripts: board gen: Default to nrfutil and align with upstream #25572

Are you sure you want to change the base?

scripts: board gen: Default to nrfutil and align with upstream #25572

Conversation

carlescufi commented Nov 13, 2025

Uh oh!

carlescufi commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

nordicjm Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NordicBuilder commented Nov 13, 2025 •

edited

Loading