Skip to content

Conversation

@noahp
Copy link
Contributor

@noahp noahp commented Nov 13, 2025

Rename the option and the name string to adhere to Bluetooth naming
convention.

See original suggestion here:

#25313 (comment)

Signed-off-by: Noah Pendleton [email protected]

Copilot AI review requested due to automatic review settings November 13, 2025 16:56
@NordicBuilder NordicBuilder added the doc-required PR must not be merged without tech writer approval. label Nov 13, 2025
Copilot finished reviewing on behalf of noahp November 13, 2025 16:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the hardware ID library's BLE-related configuration option from CONFIG_HW_ID_LIBRARY_SOURCE_BLE_MAC to CONFIG_HW_ID_LIBRARY_SOURCE_BT_MAC to align with Bluetooth naming conventions. The Kconfig option description is also updated from "BLE MAC address" to "Bluetooth Device Address".

Key changes:

  • Kconfig option renamed from CONFIG_HW_ID_LIBRARY_SOURCE_BLE_MAC to CONFIG_HW_ID_LIBRARY_SOURCE_BT_MAC
  • Kconfig option description updated to "Bluetooth Device Address"
  • All references to the old config name updated across code, tests, samples, and documentation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/hw_id/Kconfig Renames Kconfig option and updates description to follow Bluetooth naming convention
lib/hw_id/hw_id.c Updates preprocessor directives to use new BT_MAC config name
include/hw_id.h Updates preprocessor directive for HW_ID_LEN definition
tests/lib/hw_id/src/kconfig_override_ble.h Updates test configuration override to use new config name
samples/hw_id/overlay-ble-mac.conf Updates sample configuration to use new config name
doc/nrf/libraries/others/hw_id.rst Updates documentation reference to new Kconfig option
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Adds release note documenting the config rename

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 13, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 192369fb7385b2e1d3766910c1717abef5bf0b2e

more details

sdk-nrf:

PR head: 192369fb7385b2e1d3766910c1717abef5bf0b2e
merge base: 7a1b536a18daac0e53ef09332728a56125601f4c
target head (main): 7a1b536a18daac0e53ef09332728a56125601f4c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7)
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── others
│  │  │  │  │ hw_id.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  │ hw_id.h
lib
│  ├── hw_id
│  │  ├── Kconfig
│  │  │ hw_id.c
samples
│  ├── hw_id
│  │  │ overlay-ble-mac.conf
tests
│  ├── lib
│  │  ├── hw_id
│  │  │  ├── src
│  │  │  │  │ kconfig_override_ble.h

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 140
  • ✅ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@noahp noahp force-pushed the noahp/hw_id-bluetooth-naming branch from dab6f2c to 5aa2635 Compare November 13, 2025 17:54
@noahp noahp marked this pull request as ready for review November 13, 2025 18:09
@noahp noahp requested review from a team as code owners November 13, 2025 18:09
Copilot AI review requested due to automatic review settings November 13, 2025 18:09
@noahp noahp requested review from a team as code owners November 13, 2025 18:09
Copilot finished reviewing on behalf of noahp November 13, 2025 18:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Copilot AI review requested due to automatic review settings November 13, 2025 18:39
@noahp noahp force-pushed the noahp/hw_id-bluetooth-naming branch from 95e575f to 7ed6ca6 Compare November 13, 2025 18:40
Copilot finished reviewing on behalf of noahp November 13, 2025 18:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


config HW_ID_LIBRARY_SOURCE_BLE_MAC
bool "BLE MAC address"
config HW_ID_LIBRARY_SOURCE_BT_MAC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAC is the problem here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 apologies, fixed now! CONFIG_HW_ID_LIBRARY_SOURCE_BT_DEVICE_ADDRESS

Copilot AI review requested due to automatic review settings November 14, 2025 17:17
Rename the option and the name string to adhere to Bluetooth naming
convention.

See original suggestion here:

nrfconnect#25313 (comment)

Signed-off-by: Noah Pendleton <[email protected]>
Copilot finished reviewing on behalf of noahp November 14, 2025 17:19
@noahp noahp force-pushed the noahp/hw_id-bluetooth-naming branch from ee9c285 to 192369f Compare November 14, 2025 17:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noahp noahp requested a review from nordicjm November 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants