-
Notifications
You must be signed in to change notification settings - Fork 1.4k
lib: hw_id: change name "BLE" to "Bluetooth"/"BT" #25576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the hardware ID library's BLE-related configuration option from CONFIG_HW_ID_LIBRARY_SOURCE_BLE_MAC to CONFIG_HW_ID_LIBRARY_SOURCE_BT_MAC to align with Bluetooth naming conventions. The Kconfig option description is also updated from "BLE MAC address" to "Bluetooth Device Address".
Key changes:
- Kconfig option renamed from
CONFIG_HW_ID_LIBRARY_SOURCE_BLE_MACtoCONFIG_HW_ID_LIBRARY_SOURCE_BT_MAC - Kconfig option description updated to "Bluetooth Device Address"
- All references to the old config name updated across code, tests, samples, and documentation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/hw_id/Kconfig | Renames Kconfig option and updates description to follow Bluetooth naming convention |
| lib/hw_id/hw_id.c | Updates preprocessor directives to use new BT_MAC config name |
| include/hw_id.h | Updates preprocessor directive for HW_ID_LEN definition |
| tests/lib/hw_id/src/kconfig_override_ble.h | Updates test configuration override to use new config name |
| samples/hw_id/overlay-ble-mac.conf | Updates sample configuration to use new config name |
| doc/nrf/libraries/others/hw_id.rst | Updates documentation reference to new Kconfig option |
| doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst | Adds release note documenting the config rename |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 192369fb7385b2e1d3766910c1717abef5bf0b2e more detailssdk-nrf:
Github labels
List of changed files detected by CI (7)Outputs:ToolchainVersion: df3cc9d822 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
dab6f2c to
5aa2635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-25576/nrf/libraries/others/hw_id.html |
95e575f to
7ed6ca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
lib/hw_id/Kconfig
Outdated
|
|
||
| config HW_ID_LIBRARY_SOURCE_BLE_MAC | ||
| bool "BLE MAC address" | ||
| config HW_ID_LIBRARY_SOURCE_BT_MAC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAC is the problem here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 apologies, fixed now! CONFIG_HW_ID_LIBRARY_SOURCE_BT_DEVICE_ADDRESS
Rename the option and the name string to adhere to Bluetooth naming convention. See original suggestion here: nrfconnect#25313 (comment) Signed-off-by: Noah Pendleton <[email protected]>
ee9c285 to
192369f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rename the option and the name string to adhere to Bluetooth naming
convention.
See original suggestion here:
#25313 (comment)
Signed-off-by: Noah Pendleton [email protected]