Skip to content

rpc: Add command duration to rpc logging. #25587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rpc: Add command duration to rpc logging. #25587

wants to merge 1 commit into from

Conversation

@MarekPorwisz
Copy link
Contributor

@MarekPorwisz MarekPorwisz commented Nov 14, 2025

Added possibility to print RPC command duration. Time is printed as an INFO level log.

@MarekPorwisz MarekPorwisz requested review from a team as code owners November 14, 2025 10:51
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 14, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 14, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@994e3c6 (main) nrfconnect/sdk-nrfxlib#1922 nrfconnect/sdk-nrfxlib#1922/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 14, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: bd3fcf5a7cd8844f023895dc02d86294aeb556d9
nrfxlib: PR head: ec1882856c8a015c9ef3011d2f7ad8ea241c29fc

more details

sdk-nrf:

PR head: bd3fcf5a7cd8844f023895dc02d86294aeb556d9
merge base: 24999eb6a680979424ceed0237f1d45de49dc0dc
target head (main): 24999eb6a680979424ceed0237f1d45de49dc0dc
Diff

nrfxlib:

PR head: ec1882856c8a015c9ef3011d2f7ad8ea241c29fc
merge base: 994e3c6bc9530a5b59ccb29b6a4249cdbd7593b8
target head (main): 994e3c6bc9530a5b59ccb29b6a4249cdbd7593b8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6) 
nrfxlib
│  ├── nrf_rpc
│  │  ├── CHANGELOG.rst
│  │  ├── Kconfig
│  │  ├── nrf_rpc.c
│  │  ├── template
│  │  │  │ nrf_rpc_os_tmpl.h
subsys
│  ├── nrf_rpc
│  │  ├── include
│  │  │  │ nrf_rpc_os.h
west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 731
  • ✅ Integration tests
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps-main
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Damian-Nordic
Damian-Nordic reviewed Nov 14, 2025
View reviewed changes
subsys/nrf_rpc/include/nrf_rpc_os.h Outdated

static inline uint64_t nrf_rpc_os_timestamp_get_now(void)
{
return k_uptime_get();
Copy link
Contributor

@Damian-Nordic Damian-Nordic Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, maybe one minor as k_uptime_get() returns a signed integer.

Suggested change
return k_uptime_get();
return (uint64_t)k_uptime_get();

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

You can find the documentation preview for this PR here.

@MarekPorwisz MarekPorwisz force-pushed the rpc_execution_time_ncs branch 2 times, most recently from 0c0c3dd to d3dd9f9 Compare November 18, 2025 10:20
@MarekPorwisz MarekPorwisz mentioned this pull request Nov 18, 2025
Open
@MarekPorwisz MarekPorwisz force-pushed the rpc_execution_time_ncs branch from d3dd9f9 to f9887d0 Compare November 19, 2025 11:45
@MarekPorwisz
rpc: Add command duration to rpc logging.
bd3fcf5 
Added possibility to print RPC command duration. Time is printed as an
INFO level log.

Signed-off-by: Marek Porwisz <[email protected]>
@MarekPorwisz MarekPorwisz force-pushed the rpc_execution_time_ncs branch from f9887d0 to bd3fcf5 Compare November 19, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@tomaszkob89 tomaszkob89 tomaszkob89 approved these changes

@kderda kderda kderda approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-nrfxlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MarekPorwisz @NordicBuilder @tomaszkob89 @kderda @Damian-Nordic