Container attributes #3733
Open
Container attributes #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
container-attributes
branch
from
a28ae50 to
1abb88b
Compare
cthulhu-rider
force-pushed
the
container-attributes
branch
6 times, most recently
from
d136d4e to
257168b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3733 +/- ##
==========================================
- Coverage 26.50% 26.23% -0.28%
==========================================
Files 655 657 +2
Lines 41412 41838 +426
==========================================
- Hits 10978 10977 -1
- Misses 29429 29854 +425
- Partials 1005 1007 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
container-attributes
branch
from
257168b to
e0d6ff2
Compare
Support nspcc-dev/neofs-contract#564. Signed-off-by: Leonard Lyubich <[email protected]>
Support nspcc-dev/neofs-contract#564, nspcc-dev/neofs-api#360. Signed-off-by: Leonard Lyubich <[email protected]>
Follow nspcc-dev/neofs-api#360. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
container-attributes
branch
from
e0d6ff2 to
303fea6
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
Member
|
Is #3728 obsolete with this? |
| req := ev.(containerEvent.RemoveAttributeRequest) | ||
|
|
||
| cp.log.Info("notification", | ||
| zap.String("type", "set attribute"), |
| ID: id, | ||
| Attribute: req.Attribute, | ||
| Value: req.Value, | ||
| ValidUntil: time.Unix(req.ValidUntil, 0), |
Member
There was a problem hiding this comment.
Check ValidUntil here as well, fail fast.
|
|
||
| err = cp.verifySignature(signatureVerificationData{ | ||
| ownerContainer: cnr.Owner(), | ||
| verb: session.VerbContainerDelete, // TODO: session V2 |
Member
There was a problem hiding this comment.
There is VerbContainerRemoveAttribute defined already.
| commonflags.CIDFlag, | ||
| setAttributeNameFlag, | ||
| setAttributeValueFlag, | ||
| setAttributeValidForFlag, |
Member
There was a problem hiding this comment.
Shouldn't be required, have some sane default for it. Users don't care much about these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.