Don't number note-outline heading
#39
Conversation
drafting.typ
Outdated
| /// Spacing between outline elements -> relative | ||
| row-gutter: 10pt, | ||
| /// Whether the outline heading should receive a number | ||
| dont-number-heading: true, |
There was a problem hiding this comment.
Can this be number-headings: false? I like to avoid double-negatives in boolean flags
|
@Tinggaard LGTM (after the one suggested comment fix); any thoughts? I know it should probably come with a readme example, but you mentioned upgrading the distribution script (which I'd love to support!). We can probably tackle that in another PR |
This changes the default behavior of `note-outline` so that it doesn't number the heading it generates. The heading shouldn't be numbered by default because typically this notes section isn't a part of the final published document and would change the numbers of sections that are, which can cause mistakes, e.g. writing the literal "Section 6" instead of "Section 5". Closes ntjess#36
fpdotmonkey
force-pushed
the
dont-number-heading
branch
from
45b2b0d to
9025ac1
Compare
|
Yes, LGTM.
Yes, that is still in the making - sorry about the delay. Life has gotten in the way. I don't know when it will be ready, but if it is possible to make a release now, I think we should do it. There has been a few new additions since the last release, I just cannot get the build script to work, and thus have not made a PR to the official package repo. If you have suggestions to how we should build the README going forward, I am all ears. Like I have mentioned earlier I cannot get |
|
Does this require any action on my part? Happy to write an example if necessary, though I'm not quite sure what I would write as the image URL. |
For now, I think you are good - thanks! I will just await @ntjess, and hear if he has any suggestions regarding the rewrite of the CI. |
| heading(level: level, title) | ||
| heading( | ||
| level: level, | ||
| numbering: if number-heading { none } else { heading.numbering }, |
There was a problem hiding this comment.
I think this should be reversed? if number-heading { heading.numbering } else { none }
|
Apologies for being MIA, it's been a busy year 😅 Agreed, I think the CI issues are separate. |
3 participants
This changes the default behavior of
note-outlineso that it doesn't number the heading it generates. The heading shouldn't be numbered by default because typically this notes section isn't a part of the final published document and would change the numbers of sections that are, which can cause mistakes, e.g. writing the literal "Section 6" instead of "Section 5".Closes #36