Conversation
|
Thanks for the visual improvement (that we hadn't noticed as the Unicode comes out great on our computers...)! In particular, some of your changed files are not conformant to our lint settings (you can try to auto-fix with |
|
In particular for the build issues, it might be enough to add |
|
What's the rationale for setting a default height and width of 32 for the boxes and then using them at height 28 and width 24? Since there's only a unique use of each at the moment, and for the moderate foreseeable future, isn't it cleaner to have the defaults be the actual used height and width for now, and then not have to reiterate them in the uses? |
|
Thanks for updating! I see you only changed the default values in one of the two new BoxXxxx components, so they don't match any more. I would likely have just made them uniform myself and merged, except I noticed two other things:
Any thoughts/fixes on these two things? My guess on the second is that there is a very thin horizontal space in which neither the navbar link or the dropdown is considered hovered, and when the browser detects that, it closes the dropdown. Presuming so, that's a bug in main that we'd love fixed if you have any thoughts on doing so. And then my guess is that the subtle formatting changes in this PR slightly increased the height of this "no-person's-land", making the browser much more likely to close the dropdown. Again, presuming so, we definitely don't want to go in that direction since, at least in my environment as described above, it makes the Help menu very frustrating to use. |
|

Unicode boxing characters (
┤and┘) render inconsistently between browsers and have mismatched widths. I changed them to SVG components.Before
Firefox (misaligned)
Chrome/Safari (better alignment, mismatched widths)
After
all three browsers:
