Skip to content

Conversation

@buhrmi
Copy link

@buhrmi buhrmi commented Sep 3, 2015

No description provided.

@numtel
Copy link
Owner

numtel commented Sep 9, 2015

Not against this idea but not sure that this implementation is the best. It would be nice to not have the extra arguments contain a string value. Perhaps 2 boolean arguments: rowExistsNow and isUpdate instead.

Anyways, please include an update to the README.md as well as creating a test case to ensure that the correct arguments are passed. This will probably be accomplished easiest by creating a new JavaScript file and including it in test/index.js.

I recently added something similar to my mysql-live-select package: numtel/mysql-live-select@6e20eaa

If you don't feel up to all the requirements, I may give it a go but no guarantees as to the timeframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants