[Bryan Lim Jing Xiang] iP #484

bryanljx · 2022-08-27T08:51:12Z

Duke

“Your mind is for having ideas, not holding them.” – David Allen (source)

Duke frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

Download from here
double-click it
add your tasks
let it manage your tasks for you 😄

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        new Duke("data/saveFile.txt").run();
    }
}

Future improvements

Work in progress:

Improve error handling (Handle more exceptions)
Improve test coverage
Parse more date formats
Improve look and feel!

This reverts commit cbdb453.

This reverts commit 295c10a.

This reverts commit 1af53d8.

zzthian

Overall very well written to comply with the Java Coding standard. Great use of access modifiers and naming was very clear. Great job! 😀

zzthian · 2022-08-31T13:17:29Z

src/main/java/task/Task.java

+ */
+public abstract class Task {
+    private final String taskItem;
+    private boolean isMarked;


Good naming of boolean variables, makes it easier to follow the code 👍

zzthian · 2022-08-31T13:20:55Z

src/main/java/date/DeadlineDateTime.java

+     * @return DeadlineDateTime object that stores the Date and Time
+     * @throws DukeException If the storedDateTime cannot be parsed
+     */
+    public static DeadlineDateTime parseDateFromStorage(String storedDateTime) throws DukeException {


Great naming of methods, clear usage of verbs 😄

czhongwei · 2022-09-03T11:24:28Z

src/main/java/util/Ui.java

+    public static String formatLinesIntoParagraph(String... lines) {
+        String res = "";
+        for (String line : lines) {
+            res += formatLine(line);


Since you're concatenating Strings here, maybe you could consider using the StringBuilder object to optimise your code?

czhongwei

Good work! I couldn't really find any coding standard violations

MinHeinA

Could add more unit test for more of the classes.

The packages are done neatly with the related classes placed in the same folder (package). Follows good OO practices, good naming of variables and well code is well documented.

Date format for event datetime is `yyyy-mm-dd hh:mm:ss hh:mm:ss`, not `yyyy-mm hh:mm:ss hh:mm:ss hh:mm:ss`. This has been rectified in this commit.

Added validations after validating arguments/format for Todo arguments, EventDateTime, and DeadlineDateTime.

There were a few cases where String concatenation was used within a loop instead of StringBuilder, which is not ideal due to performance reasons. This was fixed in this commit.

Add Assertions

Improve code quality

damithc and others added 30 commits July 31, 2022 17:20

Add Gradle support

556af3f

Set up skeletal version of Duke

cbdb453

Revert "Set up skeletal version of Duke"

e4406e0

This reverts commit cbdb453.

Set up skeletal version of Duke

295c10a

Revert "Set up skeletal version of Duke"

e904640

This reverts commit 295c10a.

Set up skeletal version of Duke

48e4d08

Refactor text formatting to separate class

b0343fe

Add list that stores/display text entered by user

747d7ef

Add Task that can be marked/unmarked

2a968a6

Refactor formatting of multiple lines to new function

ef2e2c2

Tidy variables and return types in Task

1af53d8

Revert "Tidy variables and return types in Task"

92f6033

This reverts commit 1af53d8.

Add Task subclasses for todo, event, deadline

8d0ffd1

Update TaskList to match changes to Task

c71124f

Update duke to handle todo, event, deadline

4d6e203

Fix regex to match / instead of "

5aa7417

Update comments to match regex change

f06be8e

Update test script and files to automate testing

5ce35d8

Add error handling

0f14bf5

Add delete functionality to TaskList

41a199b

Add encoding to Tasks classes and group them into task package

8a5ae31

Refactor TextFormatter to Ui class placed in util package

87f307f

Refactor and move TaskList to tasklist package

52cc632

Refactor DukeException and add unknown task encoding exception

1695b30

Add storage class

ed33f84

Add Parser class to util pkg

308e105

Add Command abstract class

794e7d0

Move execution logic to relevant Command subclasses

2929330

Update Duke to match previous changes

9301f1f

Add data/saveFile.txt to gitIgnore

5af5b35

Merge branch 'branch-A-CodingStandard'

5299d13

bryanljx changed the title ~~[Bryan Lim Jing Xiang] ip~~ [Bryan Lim Jing Xiang] iP Aug 27, 2022

bryanljx added 2 commits August 29, 2022 14:52

Add javadocs for Find functions

1d817e1

Add import for @DisplayName annotation

ec31e4c

zzthian reviewed Aug 31, 2022

View reviewed changes

bryanljx added 4 commits September 1, 2022 16:40

Add javaFX to application

1f43423

Modify Command classes to store/return output message

6791a4f

Add gui elements

e960b7d

Update Duke and Ui according to gui changes

02ea18b

czhongwei reviewed Sep 3, 2022

View reviewed changes

MinHeinA reviewed Sep 4, 2022

View reviewed changes

bryanljx and others added 18 commits September 7, 2022 14:36

Merge tag 'Level-10'

c356bd8

Add equals method for Date Time classes

61e5dec

Add equals method for Task classes

726da86

Implement check for duplicated tasks in TaskList

fdce8bb

Update AddTaskCommand to account for duplicated tasks

49f846a

Rectify error in date format for INVALID_EVENT_DATETIME_FORMAT

e920688

Date format for event datetime is `yyyy-mm-dd hh:mm:ss hh:mm:ss`, not `yyyy-mm hh:mm:ss hh:mm:ss hh:mm:ss`. This has been rectified in this commit.

Add assertions after validating args where appropriate

a704a9d

Added validations after validating arguments/format for Todo arguments, EventDateTime, and DeadlineDateTime.

Refactor string concatenation to use StringBuilder instead

88006fa

There were a few cases where String concatenation was used within a loop instead of StringBuilder, which is not ideal due to performance reasons. This was fixed in this commit.

Enable assertions in gradle file

6f82246

Merge pull request #1 from bryanljx/branch-A-Assertions

cce9961

Add Assertions

Merge pull request #2 from bryanljx/branch-A-CodeQuality

4baa0c3

Improve code quality

Merge branch 'branch-C-DetectDuplicates'

e44b2e3

Add screenshot of app

45d6b53

Update User Guide

ce3cfa9

Update tests

54e1d55

Update build.gradle

ff6fdad

Update user guide

cec587b

Update gradle.build

af1cd6e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Bryan Lim Jing Xiang] iP #484

[Bryan Lim Jing Xiang] iP #484

Uh oh!

bryanljx commented Aug 27, 2022 •

edited

Loading

Uh oh!

zzthian left a comment

Uh oh!

zzthian Aug 31, 2022

Uh oh!

zzthian Aug 31, 2022

Uh oh!

czhongwei Sep 3, 2022

Uh oh!

czhongwei left a comment

Uh oh!

MinHeinA left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Bryan Lim Jing Xiang] iP #484

Are you sure you want to change the base?

[Bryan Lim Jing Xiang] iP #484

Uh oh!

Conversation

bryanljx commented Aug 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Duke

Future improvements

Uh oh!

zzthian left a comment

Choose a reason for hiding this comment

Uh oh!

zzthian Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

zzthian Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

czhongwei Sep 3, 2022

Choose a reason for hiding this comment

Uh oh!

czhongwei left a comment

Choose a reason for hiding this comment

Uh oh!

MinHeinA left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bryanljx commented Aug 27, 2022 •

edited

Loading

MinHeinA left a comment •

edited

Loading