[Gavin Cho] iP #530
[Gavin Cho] iP #530
Conversation
rycs2812
left a comment
rycs2812
left a comment
There was a problem hiding this comment.
Apart from the styling issues, I think the code is generally pretty okay. As long as all the increments are implemented eventually, I think the project will turn out fine!
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,14 @@ | |||
| public class Deadline extends Task { | |||
|
|
|||
| protected String by; | |||
There was a problem hiding this comment.
I think it might be better if the String had a more descriptive name, perhaps something like "date" or "deadline"?
src/main/java/Duke.java
Outdated
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
I think it might be better if there was only a single blank line here
src/main/java/Duke.java
Outdated
| if (input.equals("list")) { | ||
| System.out.println("___________________________________"); | ||
| for (int i = 0; i < counter; i++) { | ||
| System.out.println( (i+1) + "." |
There was a problem hiding this comment.
Seems like there's an extra whitespace on this line, might need to remove it to follow the coding standards
src/main/java/Duke.java
Outdated
|
|
||
| else if (input.equals("mark")) { | ||
| int number = sc.nextInt(); | ||
| collection.get(number-1).mark(); |
There was a problem hiding this comment.
Similar issue on missing/extra whitespaces, noticed this issue in several other places too, might have to address these to follow the coding standards
src/main/java/Duke.java
Outdated
| + "| |_| | |_| | < __/\n" | ||
| + "|____/ \\__,_|_|\\_\\___|\n"; | ||
| System.out.println("Hello from\n" + logo); | ||
| System.out.println("___________________________________"); |
There was a problem hiding this comment.
Perhaps the line break could be stored in a constant since it is used multiple times in the code
src/main/java/Task.java
Outdated
| @@ -0,0 +1,27 @@ | |||
| public class Task { | |||
| protected String description; | |||
| protected boolean isDone; | |||
There was a problem hiding this comment.
Good job on following the coding standards for naming boolean variables👍
ssyap98
left a comment
ssyap98
left a comment
There was a problem hiding this comment.
Overall code looks good! Just have to make some minor changes to follow the java coding standard!
src/main/java/Duke.java
Outdated
| Constants constant = Constants.valueOf(reader.next().toUpperCase()); | ||
| Task task; | ||
| switch (constant) { | ||
| case TODO: |
There was a problem hiding this comment.
There should not be indentation for the case clauses. It should look something like this
switch (constant) {
case TODO:
src/main/java/Event.java
Outdated
|
|
||
| public class Event extends Task{ | ||
|
|
||
| protected String at; |
There was a problem hiding this comment.
Maybe you can change the variable name from "at" to "eventTime" so that it sounds more meaningful?
location not found error when gui
Detecting duplicates method implemented. As a user I want to know if my planner has duplicates and if I accidentally added duplicates. Hence, this method is important
Changed return type to String so return type can be more easily accessed by the GUI.
Removed command package to fix some issues regarding the Jar FIle
3 participants
No description provided.