Skip to content

Conversation

@yamachi4416
Copy link
Contributor

@yamachi4416 yamachi4416 commented Dec 20, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I noticed that it was working in mountSuspended but not in renderSuspended.
fixed this by passing context.components, following the same approach as mountSuspended.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/test-utils@1522

commit: cbb27bc

@yamachi4416 yamachi4416 marked this pull request as ready for review December 20, 2025 00:49
@danielroe
Copy link
Member

thank you!

one thing is that there's a lot of overlap between the two implementations

i keep meaning to refactor out the shared pieces so bug fixes in one propagate to the other

@yamachi4416
Copy link
Contributor Author

yamachi4416 commented Dec 20, 2025

thank you for the review as always.
You're absolutely right. I'm going to refactor it to pull out the shared logic.

@yamachi4416 yamachi4416 marked this pull request as draft December 20, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants