cunumeric/module: implement numpy.meshgrid
#587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the function `numpy.meshgrid`.
rohany
added
the
category:new-feature
rohany
commented
Sep 18, 2022
|
|
||
| if not sparse: | ||
| # Return the full N-D matrix (not only the 1-D vector). | ||
| output = np.broadcast_arrays(*output, subok=True) |
Member
Author
There was a problem hiding this comment.
@magnatelee is there a reason why we haven't implemented broadcast, broadcast_to and broadcast_arrays? If not, I can add them relatively easily as part of this PR.
Member
Author
There was a problem hiding this comment.
sweet, i'll just wait for that.
rohany
commented
Sep 18, 2022
|
|
||
| if indexing == "xy" and ndim > 1: | ||
| # Switch first and second axis. | ||
| output[0].shape = (1, -1) + s0[2:] |
Member
Author
There was a problem hiding this comment.
This implementation from numpy muddles around with the shape parameter of the array. Is there something equivalent that I can do that works on both eager and deferred arrays? I'm not sure the right API call to make.
Contributor
|
@rohany can you sign off this pull request? you can force push changes if you need to. |
Member
Author
|
Yes, I will when the PR is ready (it's quite far from that right now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the function
numpy.meshgrid.