Logger: add a log system instead of std::cout #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrain34
force-pushed
the
dab_add_logger
branch
2 times, most recently
from
2f22d6e to
ce80c97
Compare
Found when building in 32 bits
Fix "error: enumerated and non-enumerated type in conditional expression" warning
Fix "error: enumerated and non-enumerated type in conditional expression" warning
ci: update build script for both linux and win
The ceil computation does not work as expected, and implicitly requires a C++ stanadard library exposing C++23 features
Contributor
Author
|
@zlatinski is there any issue with this PR ? The idea here is to enable from the command line the log if necessary with --logLevel There are 2 kinds of logs:
Please consider this patch as it can be very useful and avoid the use of conditional such as: |
Add a logger with level from ERROR to DEBUG Signed-off-by: Stéphane Cerveau <[email protected]>
dabrain34
force-pushed
the
dab_add_logger
branch
from
ce80c97 to
ec53232
Compare
Contributor
Author
|
Closed and moved to KhronosGroup/Vulkan-Video-Samples#5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a logger with level from ERROR to DEBUG