refactors draft

monad_lib/dune

@@ -0,0 +1,9 @@
+(library
+ (name monad_lib)
+ (public_name snarky.monad_lib)
+ (library_flags -linkall)
+ (inline_tests)
+ (libraries core_kernel)
+ (preprocess
+  (pps ppx_jane ppx_deriving.eq bisect_ppx -- --conditional))
+ (synopsis "internal monad types for snarky"))

monad_lib/monad_lib.ml

@@ -0,0 +1,3 @@
+module Monad_let = Monad_let
+module Monad_sequence = Monad_sequence
+module Restrict_monad = Restrict_monad

src/base/as_prover0.ml → src/base/as_prover.ml

@@ -12,8 +12,14 @@ end)
 (Types : Types.Types
            with type field = Backend.Field.t
             and type field_var = Backend.Cvar.t
-            and type 'a As_prover.t = (Backend.Cvar.t -> Backend.Field.t) -> 'a) =
+            and type 'a As_prover.t = (Backend.Cvar.t -> Backend.Field.t) -> 'a) : As_prover_intf.S with module Types := Types =
 struct
+  module Types = Types
+  (**
+    `t` is a monad that has access to lookup table `tbl` with type `tbl : var -> field. In Haskell parlance,
+    `t` simply `Reader (var -> field)`.
+  *)
+
   type 'a t = 'a Types.As_prover.t
 
   let map t ~f tbl =
@@ -28,12 +34,6 @@ struct
 
   let run t tbl = t tbl
 
-  let get_state _tbl s = (s, s)
-
-  let set_state s _tbl _ = (s, ())
-
-  let modify_state f _tbl s = (f s, ())
-
   let map2 x y ~f tbl =
     let x = x tbl in
     let y = y tbl in
@@ -49,7 +49,7 @@ struct
     let fields = Array.map ~f:tbl field_vars in
     value_of_fields (fields, aux)
 
-  include Monad_let.Make (struct
+  include Monad_lib.Monad_let.Make (struct
     type nonrec 'a t = 'a t
 
     let map = `Custom map

src/base/as_prover_intf.ml

@@ -1,9 +1,9 @@
-module type Basic = sig
+module type S = sig
   module Types : Types.Types
 
   type 'a t = 'a Types.As_prover.t
 
-  include Monad_let.S with type 'a t := 'a t
+  include Monad_lib.Monad_let.S with type 'a t := 'a t
 
   val run : 'a t -> (Types.field_var -> Types.field) -> 'a
 
@@ -14,7 +14,7 @@ module type Basic = sig
   val read : ('var, 'value) Types.Typ.t -> 'var -> 'value t
 
   module Provider : sig
-    type 'a t
+    type 'a t := 'a Types.Provider.t
 
     val run :
       'a t -> (Types.field_var -> Types.field) -> Request.Handler.t -> 'a option