spike out every try is a snapshot! #1313
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once a Case is loaded, we snapshot it. We may NOT have scores. But maybe that is okay? I did the quick version where after the docs are loaded we snapshot it. This is happening BEFORE the scorer runs.
@david-fisher how important is we store the scores? Historically we would store a score per query, but then, we would recalcluate everything (I think) when you would do a snapshot compare. I think the score in the snapshot_query isn't useful because we want to move to a future with multiple scorers being used!
I tried it with out 5000 queries case, and the snapshot JSON object was so big teh NGINX server puked with a 429 entity too large. But with 400 queries worked just fine.
Motivation and Context
As raised by @david-fisher in #1310 we should really think about why we aren't snapshotting every try.
How Has This Been Tested?
Screenshots or GIFs (if appropriate):
Types of changes
Checklist: