-
Couldn't load subscription status.
- Fork 6
Add rules for license copyright notice (fixes #44) #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
|
Hey, Looks great. I have a small remark: wouldn't the check flag all plugins once the year rolls over? |
|
Yep, that was the plan. For an automated scan config for existing plugins, one would probably want to disable that sub-rule. |
Check. That makes sense. |
|
I had a similar thought, but for all the plugin PRs that were submitted one year, and are still in the queue in open PRs on 1st January…. |
Perhaps adding something like an environment variable to override the year? That way, the CI checks can pass the year of the date that the PR was opened. |
|
Added two rule options, one to set the year to validate against, and one to disable the year validation entirely. |
Added a plain text parser to parse plain text files, like LICENSE. Then, added two validations as part of the
validate-licenserule.Dynalist Inc.The PR includes tests as well.
Fixes #44