Skip to content

Conversation

@mProjectsCode
Copy link
Contributor

@mProjectsCode mProjectsCode commented Oct 9, 2025

Added a plain text parser to parse plain text files, like LICENSE. Then, added two validations as part of the validate-license rule.

  1. The copyright notice may not mention Dynalist Inc.
  2. The copyright year must be up to date.

The PR includes tests as well.

Fixes #44

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (mProjectsCode)[https://github.com/mProjectsCode]
@obsidian Bot
Obsidian Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@saberzero1
Copy link
Contributor

Hey,

Looks great. I have a small remark: wouldn't the check flag all plugins once the year rolls over?

@mProjectsCode
Copy link
Contributor Author

Yep, that was the plan.

For an automated scan config for existing plugins, one would probably want to disable that sub-rule.

@saberzero1
Copy link
Contributor

Yep, that was the plan.

For an automated scan config for existing plugins, one would probably want to disable that sub-rule.

Check. That makes sense.

@claremacrae
Copy link

I had a similar thought, but for all the plugin PRs that were submitted one year, and are still in the queue in open PRs on 1st January….

@saberzero1
Copy link
Contributor

I had a similar thought, but for all the plugin PRs that were submitted one year, and are still in the queue in open PRs on 1st January….

Perhaps adding something like an environment variable to override the year? That way, the CI checks can pass the year of the date that the PR was opened.

@mProjectsCode
Copy link
Contributor Author

Added two rule options, one to set the year to validate against, and one to disable the year validation entirely.

@joethei joethei merged commit c0eccd1 into obsidianmd:master Oct 17, 2025
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule: Detect unchanged references to Dynalist

4 participants