Convert heading urls into heading links within Obsidian #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593.
I have removed the file pathname check from
string-utils.tsas it was mangling links with heading fragment likehttps://borretti.me/article/two-years-of-rust#perfinto the invalid formhttps://borretti.me/article/#perf. Many links do not end with a/and yet are not files, so this seemed like misguided truncation.I've also added a replacement that automatically converts urls containing heading links to the current (being clipped) page into proper Obsidian
[[#heading|title]]links. Unfortunately, this isn't quite perfect (see comments) but it will function perfectly on almost every website.