Skip to content

Conversation

@cg2121
Copy link
Contributor

@cg2121 cg2121 commented Apr 24, 2025

Description

This is an alternative to hiding the volume controls completely when they are hidden.

Horizontal volume controls:
Screenshot from 2025-04-23 21-06-47
Screenshot from 2025-04-23 21-07-24

Vertical volume controls:
Screenshot from 2025-04-23 21-08-26
Screenshot from 2025-04-23 21-07-59

Motivation and Context

Idea from @Warchamp7 in #7819

How Has This Been Tested?

Hid/unhid volume controls and made sure the UI looked correct.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added UI/UX Anything to do with changes or additions to UI/UX elements. Enhancement Improvement to existing functionality labels Apr 24, 2025
@cg2121 cg2121 requested a review from Warchamp7 April 24, 2025 02:39
@cg2121 cg2121 force-pushed the collapse-vol-controls branch from 6795d08 to 03ac1e1 Compare April 24, 2025 02:52
@WizardCM
Copy link
Member

I like the idea personally, but wonder if they should have some indicator when collapsed that they're muted - either via an icon or by greying out the text.

@cg2121 cg2121 force-pushed the collapse-vol-controls branch from 03ac1e1 to ad9b416 Compare April 30, 2025 10:39
@cg2121
Copy link
Contributor Author

cg2121 commented Apr 30, 2025

Updated to include @WizardCM's idea of graying out the name label when muted.

This is an alternative to hiding the volume controls completely
when they are hidden.
@cg2121
Copy link
Contributor Author

cg2121 commented Oct 16, 2025

#12735 replaces this.

@cg2121 cg2121 closed this Oct 16, 2025
@github-project-automation github-project-automation bot moved this from Ready For Review to Ready For Merge in OBS Studio 32.1 PR Considerations Oct 16, 2025
@cg2121 cg2121 deleted the collapse-vol-controls branch October 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants