libobs: Should not clear tasks while resetting audio/video #12757
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While resetting audio or video, we should not clear the task of
OBS_TASK_GRAPHICS&OBS_TASK_AUDIO.It seems the tasks cannot be cleaned until
obs_shutdownis called. When any module is callingobs_queue_task(wait=true), it will be blocked forever if the task is cleaned during resetting audio/video.Note: My only concern is whether some tasks really do need to be cleaned when resetting audio/videoMotivation and Context
Clear task of
OBS_TASK_GRAPHICS&OBS_TASK_AUDIOonly inobs_shutdownHow Has This Been Tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: