- 
                Notifications
    
You must be signed in to change notification settings  - Fork 38
 
Add owl #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add owl #341
Conversation
| 
           After much hacking with the   | 
    
| 
           Thanks for the PR @moazzammoriani! Looking at the CI, you're spot on about the issue with  
 I don't think that's going to work, unless the older version of owl doesn't depend on   | 
    
| 
           It appears that this patch doesn't quite suit the needs of this particular problem yet. I did gain some insight though into why this patch for  This implies that there are at least three points of failure: 
  | 
    
        
          
                Makefile
              
                Outdated
          
        
      | opam pin add -n --yes --switch $* eventlog-tools https://github.com/ocaml-multicore/eventlog-tools.git#multicore | ||
| opam pin add -n --yes --switch $* coq-core https://github.com/ejgallego/coq/archive/refs/tags/multicore-2021-09-29.tar.gz | ||
| opam pin add -n --yes --switch $* coq-stdlib https://github.com/ejgallego/coq/archive/refs/tags/multicore-2021-09-29.tar.gz | ||
| opam pin add -n --yes --switch $* base.0.15.0 git+https://github.com/patricoferris/base.git#500+random | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the pin to the Makefile
7765618    to
    c447e0e      
    Compare
  
    c447e0e    to
    dc1ab2c      
    Compare
  
    Remove unnecessary stanza from dune file. Change url from local repo to whatever is on the opam file on the opam repository. Add list of dependencies that are actually being installed by Sandmark. This list is useful because similar list in the README.md is inaccurate.
To dependencies/template/dev.opam: - conf-openblas - npy - update stdio To dependencies/packages: - eigen
Add opam files for owl dependencies and dependencies of its dependencies. Pin base to v0.15.0 in Makefile.
dc1ab2c    to
    fcf0dbe      
    Compare
  
    65882cc    to
    59bf19b      
    Compare
  
    9e73445    to
    8370cea      
    Compare
  
    | sudo apt-get -y install unzip aspcud libshp-dev libplplot-dev gfortran pkg-config git | ||
| git clone https://github.com/xianyi/OpenBLAS OpenBLAS | ||
| cd OpenBLAS/ | ||
| make | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is make install step?
| cd OpenBLAS/ | ||
| make | ||
| cd .. | ||
| sudo ldconfig /opt/OpenBLAS/lib/ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why /opt, and why not /usr/local/lib? The other option is to install in /home/opam and update LD_LIBRARY_PATH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure why /opt is used I just followed the Dockerfile
This is a partly concerning #331.