Repro test: no hint about missing depext #12857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Alizter
reviewed
Dec 3, 2025
| > (executable | ||
| > (name foo) | ||
| > (public_name foo) | ||
| > (libraries hi)) |
Collaborator
There was a problem hiding this comment.
Does it work with the empty (libraries) field?
Collaborator
Author
There was a problem hiding this comment.
an empty libraries field produces the same behaviour as no field at all
rgrinberg
requested changes
Dec 9, 2025
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
The test should demonstrate the issue without relying on the solver.
Collaborator
|
(That will mean writing the lock file by hand like we do for other tests. That way we can get rid of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction PR for #12855