[FIX] website: Restore arrow key navigation in search bar #4922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-split-results-dtda, it needs to be retargeted before it can be merged. |
divy-odoo
force-pushed
the
master-split-results-dtda
branch
from
6ae593b to
ee7dcef
Compare
shsa-odoo
force-pushed
the
master-split-search-keydown-issue-shsa
branch
from
be0f77f to
8b6213a
Compare
divy-odoo
force-pushed
the
master-split-results-dtda
branch
from
ee7dcef to
f4b55e0
Compare
divy-odoo
force-pushed
the
master-split-results-dtda
branch
from
f4b55e0 to
eac9afc
Compare
Issue: Arrow key navigation for search result items regressed with the new search bar layout. The previous logic in onKeydown was no longer triggered due to the updated DOM structure. Fix: Introduce a dedicated onSearchResultKeydown handler and wire it to search result items. The new method restores ArrowUp and ArrowDown focus management while keeping the existing input keydown behavior unchanged. Added a complete test case to cover arrow key navigation in search results. task-5424392
shsa-odoo
force-pushed
the
master-split-search-keydown-issue-shsa
branch
from
8b6213a to
7ec22d0
Compare
divy-odoo
force-pushed
the
master-split-results-dtda
branch
from
eac9afc to
a57de63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Arrow key navigation for search result items regressed with the new search bar layout. The previous logic in onKeydown was no longer triggered due to the updated DOM structure.
Fix:
Introduce a dedicated onSearchResultKeydown handler and wire it to search result items. The new method restores ArrowUp and ArrowDown focus management while keeping the existing input keydown behavior unchanged. Added a complete test case to cover arrow key navigation in
search results.
task-5424392