Skip to content

[FIX] pivot: error on removing max number of columns/rows #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] pivot: error on removing max number of columns/rows #7384

wants to merge 1 commit into from
+33 −13

Conversation

@hokolomopo
Copy link
Contributor

@hokolomopo hokolomopo commented Oct 29, 2025

Description

When deleting the pivot style numberOfRows or numberOfColumns in the pivot design panel, the pivot would be in error. This was because we didn't handle the cases where the content on the input was not a number, and would set NaN values.

Task: 5220970

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[FIX] pivot: error on removing max number of columns/rows
1f3ae70 
When deleting the pivot style numberOfRows or numberOfColumns in the
pivot design panel, the pivot would be in error. This was because we
didn't handle the cases where the content on the input was not a number,
and would set `NaN` values.

Task: 5220970
@robodoo
Copy link
Collaborator

robodoo commented Oct 29, 2025

Pull request status dashboard

LucasLefevre
LucasLefevre approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Nov 12, 2025
@hokolomopo
[FIX] pivot: error on removing max number of columns/rows
b2510d5 
When deleting the pivot style numberOfRows or numberOfColumns in the
pivot design panel, the pivot would be in error. This was because we
didn't handle the cases where the content on the input was not a number,
and would set `NaN` values.

closes #7384

Task: 5220970
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo added the 19.1 label Nov 12, 2025
@robodoo robodoo closed this Nov 12, 2025
@fw-bot fw-bot deleted the master-fix-pivot-design-panel-adrm branch November 19, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees

No one assigned

Labels

19.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hokolomopo @robodoo @LucasLefevre