[IMP] functions: added CHOOSE function #7399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
LucasLefevre
reviewed
Nov 3, 2025
Co-authored-by: Pierre Rousseau <[email protected]> Task: 5231138
Task: 5231138
Task: 5231138
Task: 5231138
matho-odoo
force-pushed
the
master-add-functions-matho
branch
from
b2f48f5 to
695f2c4
Compare
VincentSchippefilt
requested changes
Nov 7, 2025
Collaborator
VincentSchippefilt
left a comment
VincentSchippefilt
left a comment
There was a problem hiding this comment.
Good job for a first PR
Could you add examples of the new function in the demo data: demo/data.js
Task: 5231138
matho-odoo
force-pushed
the
master-add-functions-matho
branch
from
aeadcab to
e3820f7
Compare
hokolomopo
reviewed
Nov 21, 2025
Contributor
hokolomopo
left a comment
hokolomopo
left a comment
There was a problem hiding this comment.
Did a fast scroll in the PR, seems good :) I'll green it so Francois can test
| // CHOOSE | ||
| // ----------------------------------------------------------------------------- | ||
| export const CHOOSE = { | ||
| description: _t("An element from a list of choices based on index."), |
Contributor
There was a problem hiding this comment.
Probably missing a word in the description. Chose an element ? Return an element ?
| A1: "A1", B1: "B1", | ||
| A2: "A2", B2: "B2", | ||
| D5: "=TAKE(A1:B2,3)", E5: "", | ||
| D6: "", E6: "" |
Contributor
There was a problem hiding this comment.
nitpick: defining empty cells is kinda useless here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Pierre Rousseau [email protected]
Task: 5231138
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist