[IMP] handle untitled python files #440
Open
+398
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mmahrouss
force-pushed
the
release-handled-untitled-files-mdms
branch
from
3bef047 to
caed508
Compare
mmahrouss
force-pushed
the
release-handled-untitled-files-mdms
branch
from
caed508 to
b39ccdf
Compare
mmahrouss
force-pushed
the
release-handled-untitled-files-mdms
branch
2 times, most recently
from
2797f48 to
f341e78
Compare
fda-odoo
reviewed
Nov 4, 2025
| } | ||
|
|
||
| pub fn is_valid_for(&self, path: &PathBuf) -> bool { | ||
| if self.typ == EntryPointType::UNTITLED { |
Collaborator
There was a problem hiding this comment.
why is_valid_for is not usable for untitled entry point?
fda-odoo
requested changes
Nov 4, 2025
Collaborator
fda-odoo
left a comment
fda-odoo
left a comment
There was a problem hiding this comment.
There is a lot of duplicated code, or at least redundant ones.
Why double most of the route as "update_file_cache" and "update_untitled_file_cache"?
I would expect the actual update_file_cache to handle untitled files.
Maybe we should include scheme in path? Moreover it would let space for new schemes in the future
mmahrouss
force-pushed
the
release-handled-untitled-files-mdms
branch
from
f341e78 to
1c533e4
Compare
mmahrouss
force-pushed
the
release-handled-untitled-files-mdms
branch
from
1c533e4 to
0b8f02f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.