Fix #2: Use -fp-model=precise to enable proper floating-point error handling with OneAPI #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building NumPy with Intel OneAPI 2024.2 using -fp-model=strict, the test TestRemainder.test_float_divmod_errors[d] fails because FloatingPointError is not raised for np.divmod(np.inf, np.inf).
This happens because the strict model suppresses certain floating-point exceptions expected by NumPy. Replacing it with -fp-model=precise restores the expected behavior.
This PR updates compilation flags to:
-fp-model=precise in CFLAGS, CXXFLAGS, and FFLAGS
This resolves issue #2.