Dashboard Redesign #956
Open
Dashboard Redesign #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
force-pushed
the
dashboard-redesign
branch
6 times, most recently
from
d50202b to
6ba4c16
Compare
aanorbel
requested changes
Oct 22, 2025
Member
aanorbel
left a comment
aanorbel
left a comment
There was a problem hiding this comment.
Generally looks good. We just need to make some adjustments for the stuff like json
| } | ||
|
|
||
| private fun SelectAllWithNetwork.toModel(): ResultWithNetworkAndAggregates? { | ||
| private fun org.ooni.probe.data.ResultWithNetworkAndAggregates.toModel(): ResultWithNetworkAndAggregates? { |
Contributor
Author
There was a problem hiding this comment.
We need this one, because that's the class generated by Sqldelight, and we have another one with the same name. Or we find a better name for our ResultWithNetworkAndAggregates.
composeApp/src/commonMain/kotlin/org/ooni/probe/domain/articles/GetArticles.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/org/ooni/probe/domain/articles/GetFindings.kt
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/org/ooni/probe/domain/articles/GetFindings.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/org/ooni/probe/ui/dashboard/DashboardScreen.kt
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/org/ooni/probe/ui/dashboard/DashboardScreen.kt
Show resolved
Hide resolved
composeApp/src/commonTest/kotlin/org/ooni/probe/domain/articles/GetFindingsTest.kt
Outdated
Show resolved
Hide resolved
sdsantos
force-pushed
the
dashboard-redesign
branch
2 times, most recently
from
ec9f940 to
eb0542d
Compare
sdsantos
force-pushed
the
dashboard-redesign
branch
from
6b3ab71 to
9c4380d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #957
Just waiting for @majakomel to tell us how to show the mobile-friendly webview for findings, blog posts and reports.
https://github.com/user-attachments/assets/f24c0b72-e74b-49b5-8c18-4d5eaccd9e54
https://github.com/user-attachments/assets/c3c7ee4b-2375-4f68-ae9a-cd1cf974646c
https://github.com/user-attachments/assets/c22467e3-6512-4306-b4f3-c432e1ccf978