Skip to content

Increase OperatorPolicy test timeout on subscription adoption #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Increase OperatorPolicy test timeout on subscription adoption #412

wants to merge 1 commit into from

Conversation

@jan-law
Copy link
Contributor

@jan-law jan-law commented Nov 13, 2025

After catalogsource is patched, prevent test flakes by increasing packagemanifest timeout to match the 120s timeout in the cleanup function here

ref: https://issues.redhat.com/browse/ACM-23597

@jan-law
fix: increase timeout on subscription adoption test
eac5f91 
Prevent test flakes by increasing packagemanifest timeout
to match the 120s timeout in the cleanup function

ref: https://issues.redhat.com/browse/ACM-23597

Signed-off-by: Janelle Law <[email protected]>
@openshift-ci openshift-ci bot requested review from dhaiducek and gparvin November 13, 2025 18:58
dhaiducek
dhaiducek previously approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 😄

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2025
@jan-law
Copy link
Contributor Author

jan-law commented Nov 13, 2025

Hmm, the 120s timeout didn't help here. Before I increase the timeout again, let me look around to see how long this api call should actually take

• [FAILED] [142.795 seconds]
Testing OperatorPolicy Testing an all default operator policy [It] Should adopt an existing subscription if removed from the catalog [supports-hosted]
...
[FAILED] Timed out after 120.000s.
Expected failure, but got no error.
In [It] at: /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case38_install_operator_test.go:303 @ 11/13/25 19:03:13.874

@yiraeChristineKim
Copy link
Contributor

yiraeChristineKim commented Nov 18, 2025

/retest

@jan-law
Copy link
Contributor Author

jan-law commented Nov 18, 2025

/hold running some tests

@openshift-ci openshift-ci bot removed the lgtm label Nov 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-law

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-law

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhaiducek dhaiducek dhaiducek left review comments

@gparvin gparvin Awaiting requested review from gparvin

At least 1 approving review is required to merge this pull request.

Assignees

@dhaiducek dhaiducek

Labels

approved dco-signoff: yes do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-law @yiraeChristineKim @dhaiducek