Skip to content

Conversation

@erenatas
Copy link
Contributor

@erenatas erenatas commented Jan 3, 2026

This PR

  • Add semver violation checks using obi1kenobi/cargo-semver-checks-action to detect breaking API changes in flagd and ofrep crates. This should help us prevent wrong versioned releases in case there are unnoticed breaking changes
    https://github.com/obi1kenobi/cargo-semver-checks

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

Add semver violation checks using obi1kenobi/cargo-semver-checks-action
to detect breaking API changes in the Rust workspace crates.
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@erenatas erenatas changed the title chore(ci): add cargo-semver-checks to lint workflow chore(ci): add cargo-semver-checks to flagd/ofrep release PRs Jan 3, 2026
- 'crates/flagd/**'
- 'crates/ofrep/**'
- '.github/workflows/flagd-ofrep-check.yml'
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double definition of pull_request?

I don’t see this action running in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look at it this week, btw @erka would you consider being a Rust contributor in open-feature org? Your comments are valuable and very helpful and I would be more than happy to have your support 🙇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to the idea in general. Time is the only limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants