-
Notifications
You must be signed in to change notification settings - Fork 12
chore(ci): add cargo-semver-checks to flagd/ofrep release PRs #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add semver violation checks using obi1kenobi/cargo-semver-checks-action to detect breaking API changes in the Rust workspace crates.
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Signed-off-by: Eren Atas <[email protected]>
Signed-off-by: Eren Atas <[email protected]>
Signed-off-by: Eren Atas <[email protected]>
0a693a4 to
7b31ccd
Compare
| - 'crates/flagd/**' | ||
| - 'crates/ofrep/**' | ||
| - '.github/workflows/flagd-ofrep-check.yml' | ||
| pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double definition of pull_request?
I don’t see this action running in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look at it this week, btw @erka would you consider being a Rust contributor in open-feature org? Your comments are valuable and very helpful and I would be more than happy to have your support 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to the idea in general. Time is the only limitation.
This PR
https://github.com/obi1kenobi/cargo-semver-checks
Related Issues
Fixes #1234523
Notes
Follow-up Tasks
How to test